1237191 - [WebGL2] pass getQueryParameter in gl-object-get-calls.html

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Ethan Lin[:ethlin]]

Test getQueryParameter
FAIL gl.getQueryParameter(query, gl.QUERY_RESULT_AVAILABLE) should be false (of type boolean). Was null (of type object).
FAIL getQueryParameter did not generate INVALID_ENUM for invalid pname enum: NO_ERROR

Comment 1

[Ethan Lin[:ethlin]]

Attachment: Add check for getQueryParameter

Add some checks to return correct gl error.

Comment 2

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8704529 [details] [diff] [review]
Add check for getQueryParameter

Review of attachment 8704529 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGL2ContextQueries.cpp
@@ +295,5 @@
>  
>      if (IsContextLost())
>          return;
>  
> +    if (!ValidateQueryEnum(pname, "getQueryParameter"))

Just define this function above this function:

static bool
ValidateQueryEnum(WebGLContext* webgl, pname, funcName)

::: dom/canvas/WebGLContext.h
@@ +1285,5 @@
>      bool ValidateCurFBForRead(const char* funcName,
>                                const webgl::FormatUsageInfo** const out_format,
>                                uint32_t* const out_width, uint32_t* const out_height);
>  
> +    bool ValidateQueryEnum(GLenum pname, const char* info);

No need to add a member for this.

Comment 3

[Ethan Lin[:ethlin]]

Attachment: Add check for getQueryParameter(carry r+: jgilbert)

try server result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0997d16adc27

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/adfe8792f603

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/adfe8792f603