Closed Bug 1237330 Opened 5 years ago Closed 5 years ago

Taskcluster 2.5 mulet builds need to be made.

Categories

(Taskcluster :: Services, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla46

People

(Reporter: nhirata, Unassigned)

References

Details

Attachments

(3 files, 2 obsolete files)

We need 2.5 mulet builds on taskcluster for mac/linux/win.
Not sure if this is all what needs to be changed.

Greg, could I get your input please if this is all what needs to be done or is there more to make linux mulet builds for 2.5?
Attachment #8705408 - Flags: feedback?(garndt)
Comment on attachment 8705408 [details] [diff] [review]
0001-bug-1237330-mulet-for-2.5-linux-64-build.patch

Review of attachment 8705408 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, just one minor comment.  I think this should work out.  If you're familiar with the 'taskcluster-graph' mach target, you could run this for this repo, and make sure that the tasks are in the json that is printed out the way you expect it.

::: testing/taskcluster/tasks/post-builds/mulet_simulator.yml
@@ -6,4 @@
>    created: '{{now}}'
>    deadline: '{{#from_now}}24 hours{{/from_now}}'
>    metadata:
> -    source: https://hg.mozilla.org/mozilla-central/file/tip/b2g/simulator

Perhaps this should be head_repository in case this is enabled on try?  Also, we might want to replace 'tip' with {{head_rev}}
Attachment #8705408 - Flags: feedback?(garndt) → feedback+
Fixed nit.  Tested with : ./mach taskcluster-graph --project='mozilla-central' --message='testing patch' --owner='nhirata@mozilla.com' --head-repository https://hg.mozilla.org/releases/mozilla-b2g44_v2_5 --head-rev tip --print-names-only
Attachment #8705408 - Attachment is obsolete: true
Attachment #8705812 - Flags: review?(garndt) → review+
Windows and Mac haven't been migrated to taskcluster.  I think those two bugs will have to be resolved first if we are to build via Taskcluster; otherwise we would have to use buildbot.
Depends on: 1171592, 1171601
Oh I came to realize.  I think we need to push this to the 2.5 branch as well after checkin?
Keywords: checkin-needed
Wes, Does Taskcluster automatically get picked up by the checkin-needed script?
Flags: needinfo?(wkocher)
It's in the list for checkin-needed stuff, but the trees are currently closed for infra issues, so nothing's getting landed at the moment.
Flags: needinfo?(wkocher)
this failed to apply:

applying 0001-bug-1237330-mulet-for-2.5-linux-64-build.patch
patching file testing/taskcluster/tasks/post-builds/mulet_simulator.yml
Hunk #1 FAILED at 5
1 out of 1 hunks FAILED -- saving rejects to file testing/taskcluster/tasks/post-builds/mulet_simulator.yml.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh 0001-bug-1237330-mulet-for-2.5-linux-64-build.patch
Flags: needinfo?(nhirata.bugzilla)
Keywords: checkin-needed
Source was changed to "source: '{{source}}' " which is cleaner so I removed that part from my patch.
Attachment #8705812 - Attachment is obsolete: true
Flags: needinfo?(nhirata.bugzilla)
Comment on attachment 8706532 [details] [diff] [review]
0001-bug-1237330-mulet-for-2.5-linux-64-build.patch

Not sure if you need to review again before checkin...
Attachment #8706532 - Flags: review?(garndt)
Attachment #8706532 - Flags: review?(garndt) → review+
https://hg.mozilla.org/mozilla-central/rev/0fc6f76fe6a9
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Uplift patch for 2.5 ; I think the uplift is needed for mulet to be trigger for 2.5...
Flags: needinfo?(mpotharaju)
Attachment #8707692 - Flags: review?(garndt)
Attachment #8707692 - Flags: review?(garndt) → review+
Just one question about this patch though, where is {{source}} coming from?
Looking over this command, it seems source is set for build_parameters, which is then used by post-build tasks, but that source will be for the parent build task, not the source of the file for building the simulator if I'm understanding correctly.

https://dxr.mozilla.org/mozilla-central/source/testing/taskcluster/mach_commands.py#473
Comment on attachment 8706532 [details] [diff] [review]
0001-bug-1237330-mulet-for-2.5-linux-64-build.patch

Please uplift this to 2.5

Thanks
Flags: needinfo?(mpotharaju)
Attachment #8706532 - Flags: approval‑mozilla‑b2g44+
Comment on attachment 8707692 [details] [diff] [review]
0001-Bug-1237330-uplift-for-2.5.patch

Please uplift this to 2.5

Thanks
Attachment #8707692 - Flags: approval‑mozilla‑b2g44+
Comment on attachment 8706532 [details] [diff] [review]
0001-bug-1237330-mulet-for-2.5-linux-64-build.patch

Sorry, wrong patch approved at first. Removing the flag on this patch
Attachment #8706532 - Flags: approval‑mozilla‑b2g44+
We need the task to be on 2.5; this patch is directly for the 2.5 branch.
Comment on attachment 8708540 [details] [diff] [review]
0001-Bug-1237330-need-linux64-mulet-build-task.patch

Review of attachment 8708540 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like this should do it.
Attachment #8708540 - Flags: review?(garndt) → review+
Comment on attachment 8708540 [details] [diff] [review]
0001-Bug-1237330-need-linux64-mulet-build-task.patch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
User impact if declined: No Mulet 2.5 builds; no TV testing.

Mahe, can you approve this please?
Flags: needinfo?(mpotharaju)
Attachment #8708540 - Flags: approval‑mozilla‑b2g44?
Comment on attachment 8708540 [details] [diff] [review]
0001-Bug-1237330-need-linux64-mulet-build-task.patch

Please uplift this batch onto 2.5.

Thanks
Flags: needinfo?(mpotharaju)
Attachment #8708540 - Flags: approval‑mozilla‑b2g44? → approval‑mozilla‑b2g44+
Moving closed bugs across to new Bugzilla product "TaskCluster".
Component: TaskCluster → Integration
Flags: approval‑mozilla‑b2g44+
Product: Testing → Taskcluster
Component: Integration → Services
You need to log in before you can comment on or make changes to this bug.