1237330 - Taskcluster 2.5 mulet builds need to be made.

Status: RESOLVED FIXED

(Taskcluster :: Services, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

We need 2.5 mulet builds on taskcluster for mac/linux/win.

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: 0001-bug-1237330-mulet-for-2.5-linux-64-build.patch

Not sure if this is all what needs to be changed.

Greg, could I get your input please if this is all what needs to be done or is there more to make linux mulet builds for 2.5?

Comment 2

[Greg Arndt [:garndt]]

Comment on attachment 8705408 [details] [diff] [review]
0001-bug-1237330-mulet-for-2.5-linux-64-build.patch

Review of attachment 8705408 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, just one minor comment.  I think this should work out.  If you're familiar with the 'taskcluster-graph' mach target, you could run this for this repo, and make sure that the tasks are in the json that is printed out the way you expect it.

::: testing/taskcluster/tasks/post-builds/mulet_simulator.yml
@@ -6,4 @@
>    created: '{{now}}'
>    deadline: '{{#from_now}}24 hours{{/from_now}}'
>    metadata:
> -    source: https://hg.mozilla.org/mozilla-central/file/tip/b2g/simulator

Perhaps this should be head_repository in case this is enabled on try?  Also, we might want to replace 'tip' with {{head_rev}}

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: 0001-bug-1237330-mulet-for-2.5-linux-64-build.patch

Fixed nit.  Tested with : ./mach taskcluster-graph --project='mozilla-central' --message='testing patch' --owner='[e-mail]' --head-repository https://hg.mozilla.org/releases/mozilla-b2g44_v2_5 --head-rev tip --print-names-only

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Windows and Mac haven't been migrated to taskcluster.  I think those two bugs will have to be resolved first if we are to build via Taskcluster; otherwise we would have to use buildbot.

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Oh I came to realize.  I think we need to push this to the 2.5 branch as well after checkin?

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Wes, Does Taskcluster automatically get picked up by the checkin-needed script?

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

It's in the list for checkin-needed stuff, but the trees are currently closed for infra issues, so nothing's getting landed at the moment.

Comment 8

[Carsten Book [:Tomcat]]

this failed to apply:

applying 0001-bug-1237330-mulet-for-2.5-linux-64-build.patch
patching file testing/taskcluster/tasks/post-builds/mulet_simulator.yml
Hunk #1 FAILED at 5
1 out of 1 hunks FAILED -- saving rejects to file testing/taskcluster/tasks/post-builds/mulet_simulator.yml.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh 0001-bug-1237330-mulet-for-2.5-linux-64-build.patch

Comment 9

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: 0001-bug-1237330-mulet-for-2.5-linux-64-build.patch

Source was changed to "source: '{{source}}' " which is cleaner so I removed that part from my patch.

Comment 10

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Comment on attachment 8706532 [details] [diff] [review]
0001-bug-1237330-mulet-for-2.5-linux-64-build.patch

Not sure if you need to review again before checkin...

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0fc6f76fe6a9

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0fc6f76fe6a9

Comment 13

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: 0001-Bug-1237330-uplift-for-2.5.patch

Uplift patch for 2.5 ; I think the uplift is needed for mulet to be trigger for 2.5...

Comment 14

[Greg Arndt [:garndt]]

Just one question about this patch though, where is {{source}} coming from?

Comment 15

[Greg Arndt [:garndt]]

Ah, disregard, I see this now https://dxr.mozilla.org/mozilla-central/source/testing/taskcluster/mach_commands.py#392

Comment 16

[Greg Arndt [:garndt]]

Looking over this command, it seems source is set for build_parameters, which is then used by post-build tasks, but that source will be for the parent build task, not the source of the file for building the simulator if I'm understanding correctly.

https://dxr.mozilla.org/mozilla-central/source/testing/taskcluster/mach_commands.py#473

Comment 17

[Mahendra Potharaju [:mahe]]

Comment on attachment 8706532 [details] [diff] [review]
0001-bug-1237330-mulet-for-2.5-linux-64-build.patch

Please uplift this to 2.5

Thanks

Comment 18

[Mahendra Potharaju [:mahe]]

Comment on attachment 8707692 [details] [diff] [review]
0001-Bug-1237330-uplift-for-2.5.patch

Please uplift this to 2.5

Thanks

Comment 19

[Mahendra Potharaju [:mahe]]

Comment on attachment 8706532 [details] [diff] [review]
0001-bug-1237330-mulet-for-2.5-linux-64-build.patch

Sorry, wrong patch approved at first. Removing the flag on this patch

Comment 20

[Carsten Book [:Tomcat]]

landed as  https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/a37f271b0ddf

Comment 21

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: 0001-Bug-1237330-need-linux64-mulet-build-task.patch

We need the task to be on 2.5; this patch is directly for the 2.5 branch.

Comment 22

[Greg Arndt [:garndt]]

Comment on attachment 8708540 [details] [diff] [review]
0001-Bug-1237330-need-linux64-mulet-build-task.patch

Review of attachment 8708540 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like this should do it.

Comment 23

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Comment on attachment 8708540 [details] [diff] [review]
0001-Bug-1237330-need-linux64-mulet-build-task.patch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
User impact if declined: No Mulet 2.5 builds; no TV testing.

Mahe, can you approve this please?

Comment 24

[Mahendra Potharaju [:mahe]]

Comment on attachment 8708540 [details] [diff] [review]
0001-Bug-1237330-need-linux64-mulet-build-task.patch

Please uplift this batch onto 2.5.

Thanks

Comment 25

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/b37e97169695

Comment 26

[Pete Moore [:pmoore][:pete]]

Moving closed bugs across to new Bugzilla product "TaskCluster".