1237367 - copy exif on share image

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Hubert Figuiere [:hub]]

Follow-up to bug 1178812 : we need to copy Exif for the share action. See frames.js:shareSingleItem()

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] hfiguiere:bug1237367-exif-copy-share > mozilla-b2g:master

Comment 2

[Hubert Figuiere [:hub]]

Comment on attachment 8705807 [details] [review]
[gaia] hfiguiere:bug1237367-exif-copy-share > mozilla-b2g:master

Punam, if you don't mind reviewing this. Thanks !

Comment 3

[Punam Dahiya [:pdahiya]]

Hi Hub

I am following below steps to test exif copy on single file share action.

1. Share file in gallery with messaging app

2. Send the message with the shared file.

3. Open the shared message and click on the attachment and save the attached image.

4. Saved image should show up in gallery

With the patch, I was expecting to see EXIF info with the saved image but I don't see it. Am I missing something?

I am using https://github.com/recurser/exif-orientation-examples/blob/master/Portrait_6.jpg to test the above flow. Thanks!

Comment 4

[Punam Dahiya [:pdahiya]]

Comment on attachment 8705807 [details] [review]
[gaia] hfiguiere:bug1237367-exif-copy-share > mozilla-b2g:master

Issue reported in comment #3 resolved for me with re-flash of flame. EXIF data is seen on shared image. Thanks!

Comment 5

[Hubert Figuiere [:hub]]

Merged
https://github.com/mozilla-b2g/gaia/commit/aee2763847b1b289f4876b04de78f06ee31e22c5