44 bytes, text/x-github-pull-request
|Details | Review | Splinter Review|
According to GitHub, ujson went from 1.33 (which we currently use in socorro) to 1.34 in April 2014. Meaning we're running a 2 year-old version. From clicking and skimming around the git logs, it seems the biggest changes are around UTF8, ability to sort keys, changes to unit tests and changes to benchmarks. It's hard to understand if these differences would remedy any of the OutOfMemory errors we've seen in processors in production. Having breakpad JSON outputs  that take down ujson would be a massive asset in justifying this upgrade.  https://bugzilla.mozilla.org/show_bug.cgi?id=1235436#c3
I believe lars has the specific crash ids that result in ujson segfaulting if you want to test.
(In reply to Chris Lonnen :lonnen from comment #1) > I believe lars has the specific crash ids that result in ujson segfaulting > if you want to test. Yes please. I'm also curious to learn out to use that Crash ID to get to the stackwalker output locally.
We use ujson 1.33. Today, the latest version is 1.35. 1.33 is 953 days older than 1.35!
Created attachment 8717468 [details] [review] Link to Github pull-request: https://github.com/mozilla/socorro/pull/3190 If this doesn't work, i.e. it still causes spurious odd memory errors, *then* I'm going to ditch ujson and switch back to the much slower simplejson.
Commits pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/d1dab3c5ecf0e2420093e23b39e30fdcb5b0605c fixes bug 1237386 - Upgrade to ujson 1.35 https://github.com/mozilla/socorro/commit/63f4943d8945fc860b4826c5c2971e6479c216c3 Merge pull request #3190 from peterbe/bug-1237386-upgrade-to-ujson-135 fixes bug 1237386 - Upgrade to ujson 1.35