123740 - Add <label> to email prefs

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect, P3)

Description

[Christian Reis]

We need <label> support for all those email preferences.

Comment 1

[Christian Reis]

Let's get this reviewed :-)

Comment 2

[Christian Reis]

Attachment: kiko_v1: add label to emailprefs

This implements label for all options on the email preferences page. No, I
don't want to make this patch any larger, nor should it include any other label
additions apart from the email prefs page. :-)

Comment 3

[Christian Reis]

-> me

Comment 4

[Bradley Baetz (:bbaetz)]

Isn't this being done as part of the userprefs.cgi templatisation?

Comment 5

[Christian Reis]

Possibly. I wasn't aware this was on-going. bug 117060 it is.

Well, Gerv isn't adding <label>s there, but I don't want to hang him up, so I'll
set a dependency.

Comment 6

[Dave Miller [:justdave]]

Comment on attachment 68068 [details] [diff] [review]
kiko_v1: add label to emailprefs

this is bitrotted because it got templatized...

Comment 7

[Tobias Burnus]

Attachment: v2: Update using account/prefs/email.html.tmpl

This patch is very small due to the redesign of the email preference table.

Comment 8

[Gervase Markham [:gerv]]

Comment on attachment 92933 [details] [diff] [review]
v2: Update using account/prefs/email.html.tmpl

2xr=gerv.

Gerv

Comment 9

[Gervase Markham [:gerv]]

Fixed.

Checking in ./template/en/default/account/prefs/email.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/prefs/email.html.tmpl,v
 <--  email.html.tmpl
new revision: 1.6; previous revision: 1.5
done

Gerv