1237428 - Element pretty print only shows 10 attributes, does not indicate there are more

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

STR:

1. Go to https://output.jsbin.com/quziba/2
2. Inspect the div
3. The inspector displays all 12 attributes
4. Switch to console
5. Log the element with $0

ER:

10 attributes should be printed, plus the ", more" label

AR:

10 attributes are printed, no indication there could be more

Comment 1

[Brian Grinstead [:bgrins]]

There is a limit of 10 set on the number of attributes set on an object: https://dxr.mozilla.org/mozilla-central/source/devtools/server/actors/object.js#24.

I guess we could skip that for DOM attributes though

Comment 2

[Brian Grinstead [:bgrins]]

Specific code that's stopping for DOM Nodes: https://dxr.mozilla.org/mozilla-central/source/devtools/server/actors/object.js#1499

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

It looks like the server does not include any data about whether there are more than the limit?

So yeah, we could just skip the limit for attributes, or add something so the client can tell there are more.

Comment 4

[Brian Grinstead [:bgrins]]

Attachment: MozReview Request: Bug 1237428 - Don't cap number of attributes on DOM nodes in console;r=jryans

Review commit: https://reviewboard.mozilla.org/r/29771/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29771/

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8704837 [details]
MozReview Request: Bug 1237428 - Don't cap number of attributes on DOM nodes in console;r=jryans

https://reviewboard.mozilla.org/r/29771/#review26609

Great, thanks!

Comment 6

[Brian Grinstead [:bgrins]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9469913e250e&selectedJob=15141904

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/f08d1e52d609

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f08d1e52d609

Comment 9

[Khalid Syfullah Zaman [:khalid32]]

I have reproduced this bug on Nightly 46.0a1 (2016-01-06) on ubuntu 14.04 LTS, 32 bit!

The bug's fix is now verified on Latest Beta 46.0b2!

Build ID: 20160316065941
User Agent: Mozilla/5.0 (X11; Linux i686; rv:46.0) Gecko/20100101 Firefox/46.0

Comment 10

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> VERIFIED

Comments: Test not successful
STR:  Clear.


Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
10 element printed at least

Actual Results: 
After switching to console and entering $0 into filter output, no element gets printed.