Closed Bug 1237428 Opened 8 years ago Closed 8 years ago

Element pretty print only shows 10 attributes, does not indicate there are more

Categories

(DevTools :: Console, defect)

defect
Not set
normal

Tracking

(firefox46 verified)

RESOLVED FIXED
Firefox 46
Tracking Status
firefox46 --- verified

People

(Reporter: jryans, Assigned: bgrins)

References

()

Details

Attachments

(1 file)

STR:

1. Go to https://output.jsbin.com/quziba/2
2. Inspect the div
3. The inspector displays all 12 attributes
4. Switch to console
5. Log the element with $0

ER:

10 attributes should be printed, plus the ", more" label

AR:

10 attributes are printed, no indication there could be more
There is a limit of 10 set on the number of attributes set on an object: https://dxr.mozilla.org/mozilla-central/source/devtools/server/actors/object.js#24.

I guess we could skip that for DOM attributes though
It looks like the server does not include any data about whether there are more than the limit?

So yeah, we could just skip the limit for attributes, or add something so the client can tell there are more.
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Comment on attachment 8704837 [details]
MozReview Request: Bug 1237428 - Don't cap number of attributes on DOM nodes in console;r=jryans

https://reviewboard.mozilla.org/r/29771/#review26609

Great, thanks!
Attachment #8704837 - Flags: review?(jryans) → review+
https://hg.mozilla.org/mozilla-central/rev/f08d1e52d609
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Depends on: 1237886
I have reproduced this bug on Nightly 46.0a1 (2016-01-06) on ubuntu 14.04 LTS, 32 bit!

The bug's fix is now verified on Latest Beta 46.0b2!

Build ID: 20160316065941
User Agent: Mozilla/5.0 (X11; Linux i686; rv:46.0) Gecko/20100101 Firefox/46.0
QA Whiteboard: [testday-20160318]
[bugday-20160323]

Status: RESOLVED,FIXED -> VERIFIED

Comments: Test not successful
STR:  Clear.


Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
10 element printed at least

Actual Results: 
After switching to console and entering $0 into filter output, no element gets printed.
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: