Remove Animation::mInEffectOnLastAnimationTimingUpdate and just use mProgressOnLastCompose

NEW
Unassigned

Status

()

3 years ago
3 years ago

People

(Reporter: birtles, Unassigned)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox46 affected)

Details

(Reporter)

Description

3 years ago
Bug 1232563 introduced an mProgressOnLastCompose member to Animation. We can use this to do roughly the same thing as mInEffectOnLastAnimationTimingUpdate does.

Specifically, mProgressOnLastCompose will be null if we were not in-effect on the last *ComposeStyle*. That's a bit different to mInEffectOnLastAnimationTimingUpdate which is only updated on each call to NotifyAnimationTimingUpdated.

I think that's only problematic if it is possible to transition in or out of the "in effect" state and call ComposeStyle *without* triggering a call to NotifyAnimationTimingUpdated. i.e. if we had such a transition, called ComposeStyle, updated mProgressOnLastCompose, and then later called NotifyAnimationTimingUpdated we'd fail to notice the change in "in effect" state and potentially fail to update the animation cascade. So I guess we just need to be careful to ensure that is always the case.
You need to log in before you can comment on or make changes to this bug.