1237462 - Enable test_mutationobservers.html with e10s

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrew McCreight [:mccr8]]

dom/base/test/test_mutationobservers.html is disabled with e10s because it uses showModalDialog, but it really only uses it for one subtest. That test could be moved into a separate test, or maybe test_mutationobservers.html could just be enabled for e10s. It seems to handle the case where showModalDialog by catching an exception.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

showModalDialog either must be implemented in e10s or hidden from window interface.
And then the test could just check if showModalDialog is available and if not, continue to the next subtest.
try-catch around showModalDialog might be indeed enough.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Seems to work locally
https://treeherder.mozilla.org/#/jobs?repo=try&revision=74e38aad93f5

Comment 3

[Andrew McCreight [:mccr8]]

Comment on attachment 8704884 [details] [diff] [review]
patch

Review of attachment 8704884 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/56170016142d

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/56170016142d