1237463 - LSPAnnotator enhancements and bug fixes

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[(No longer employed by Mozilla) Aaron Klotz]

When investigating an LSP crash, I noticed that we are missing some very useful information from the LSP annotations.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Patch

This patch adds the following additional data for each protocol entry:

- Address family;
- Protocol;
- Service flags;
- Provider flags;
- Category flags (if available);
- Provider GUID (if the provider is a base or layer provider, not a chain)

The output always includes the separators for the optional fields even if they're not populated in order to make the annotation easier to parse.

I also fixed a bug where we would sometimes fail to retrieve the path to the LSP binary.

Comment 2

[Jim Mathies [:jimm]]

Comment on attachment 8704876 [details] [diff] [review]
Patch

Review of attachment 8704876 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/windows/LSPAnnotator.cpp
@@ +116,5 @@
> +    // Windows as to which order to chain the providers.
> +    nsModuleHandle ws2_32(LoadLibraryW(L"ws2_32.dll"));
> +    if (ws2_32) {
> +      WSCGetProviderInfoFnPtr pWSCGetProviderInfo = (WSCGetProviderInfoFnPtr)
> +        GetProcAddress(ws2_32, "WSCGetProviderInfo");

How about using decltype here, something like -

decltype(WSCGetProviderInfo)* pWSCGetProviderInfo = (decltype(WSCGetProviderInfo)*) GetProcAddress(ws2_32, "WSCGetProviderInfo");

and then you can get rid of the typedef up above.

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Patch (r2)

Revised with jimm's suggestions. Carrying forward r+.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e5a4787cccce

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e5a4787cccce

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out in https://hg.mozilla.org/mozilla-central/rev/0f363ae95dc9 because it apparently caused a huge spike in Win8 debug Cpp test failures.

The failures are all hitting different tests, but they all seem to end in "test failed with return code 2147483651"

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Example failure: https://treeherder.mozilla.org/logviewer.html#?job_id=3033470&repo=mozilla-central

Comment 8

[(No longer employed by Mozilla) Aaron Klotz]

This was caused by bug 1204784.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8fdeee3bdee6

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8fdeee3bdee6