Move smart-dialog to fxos-components and rename it to fxos-tv-dialog

RESOLVED FIXED

Status

Firefox OS
Gaia::Components
P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: yifan, Assigned: yifan)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

User Story

This meta will gather tasks that improve smart component. The idea is making smart component to be re-usable common component.

Requirement:
- move all all smart component to fxos-component organization (https://github.com/fxos-components)
- migrate package manager from bower to npm3
- correct bower and npm3 package dependencies

Used Smart Components:
- smart-banner
- smart-button
- smart-scrollbox
- smart-icons
- smart-modal-dialog
- smart-bubbles
- smart-dialog

Attachments

(1 attachment)

56 bytes, text/x-github-pull-request
rexboy
: review+
Details | Review | Splinter Review
(Assignee)

Description

2 years ago
+++ This bug was initially created as a clone of Bug #1237484 +++

And publish it to npm.
(Assignee)

Updated

2 years ago
No longer depends on: 1237484
(Assignee)

Updated

2 years ago
Assignee: nobody → yliao
(Assignee)

Comment 1

2 years ago
Created attachment 8709262 [details] [review]
pull request

Move smart-dialog from gaia-components to fxos-components and rename it to fxos-tv-dialog.
Attachment #8709262 - Flags: review?(rexboy)
(Assignee)

Updated

2 years ago
Status: NEW → ASSIGNED
Comment on attachment 8709262 [details] [review]
pull request

Looks good but we need another bug to met npm package format.
Attachment #8709262 - Flags: review?(rexboy) → review+
(Assignee)

Comment 3

2 years ago
https://github.com/fxos-components/fxos-tv-dialog/commit/279b0b8d786acf45b850cb3f69ea6fada7251b43
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Assignee)

Updated

2 years ago
Blocks: 1243250
You need to log in before you can comment on or make changes to this bug.