1237527 - Cookies are all gone after Firefox crashes after experiencing a full disk

Status: NEW

(Core :: Networking: Cookies, defect, P3)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Happens on Firefox Mac 44.0b6, built from https://hg.mozilla.org/releases/mozilla-beta/rev/9ebad515bc39afdea1e656bf15218a0511a5d1e2

My disk space is running low and Firefox crashes when Mac shows the warning (the crash itself is another bug...), after restart all my cookies are gone and I have to re-login to all services.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

It looks like that on any error, the cookie database tries to rebuild itself by nuking the DB and writing out all the cookies again.  (The cookies are all in memory all the time, so this is a thing that can be done.)
https://dxr.mozilla.org/mozilla-central/source/netwerk/cookie/nsCookieService.cpp#340

Unfortunately, if your disk is full and getting actively filled up by some other process, it's likely the following happens:
- SQLite generates a SQLITE_FULL error that gets mapped to an NS_ERROR_FILE_NO_DEVICE_SPACE
- The cookie service error handler tries to create the database anew
- Maybe Firefox crashes?
- It goes to create the database but SQLITE_FULL errors keep happening and so it keeps re-creating things or just gives up or whatever.  I didn't look into this too much.

When the disk is filling up/full, there aren't a lot of good options, but probably the safest one for the cookie service would be to handle the full event and treat it as an "oh well, there's nothing I can do but I definitely won't delete the cookie database".

Unfortunately I'm assuming your full disk scenario might have also resulted in there being no crash in about:crashes?

cc'ing :mak because full-disk crashes are an interesting mozStorage-related thing.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Andrew Sutherland [:asuth] from comment #1)
> Unfortunately I'm assuming your full disk scenario might have also resulted
> in there being no crash in about:crashes?

That's right, no about:crashes :'(

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This just happen to me again. Strangely, for the second time, Bugzilla cookie survives.

Comment 4

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 5

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258