1237585 - taskcluster-github prod base URL should be under domain github.taskcluster.net

Status: RESOLVED FIXED

(Taskcluster :: Services, defect)

Description

[Pete Moore [:pmoore][:pete]]

See:

https://github.com/taskcluster/taskcluster-github/blob/a96d4035e4acb56ca35f435e35aa4ff09e53fe3a/config/production.js#L18

https://taskcluster-github.herokuapp.com should be https://github.taskcluster.net to be consistent with our other services (see bug 1237575 for an overview). Also maybe this is needed to work correctly with our *.taskcluster.net ssl certificate(?).

As well as the code change, it looks like we will also need to replace the existing CNAME record for `github.taskcluster.net` which currently points to `taskcluster-github.herokuapp.com`, for a new record pointing to `shizuoka-5876.herokussl.com` (to be consistent with our other domains). I'm not sure if any config is needed in order for shizuoka-5876.herokussl.com to handle the requests. We could just add an extra CNAME record rather than replacing the existing one, but it seems cleanest to remove the old one at the same time, so that we have only a single endpoint we manage and expect.

I'm not sure if anything else is required, or just a redeploy of the service.

It may also be that existing github webhooks need to be updated at least for taskcluster/mozilla github organizations, in order to reference the updated domain name rather than the old one. I'm not sure if anything else points to the current name "taskcluster-github.herokuapp.com".

Thanks guys!

NI'ing Morgan who wrote the service, Jake who maintains it, and Jonas who I'm pretty sure set up the *.taskcluster.net domains. Let me know if I missed any steps, or if you have other information that is relevant about how we should roll this out. Thanks!

Comment 1

[Jonas Finnemann Jensen (:jonasfj)]

1) File a bug to:
  CNAME github.taskcluster.net -> shizuoka-5876.herokussl.com
2) Add as github.taskcluster.net on the heroku app for taskcluster-github

This works because we share the same HTTPS end-point on heroku.
(1) and (2) is all it takes. (2) seems to already be done.

Comment 2

[Jonas Finnemann Jensen (:jonasfj)]

@jake, You can get dustin to make the DNS change or file a bug.
I'm leaving it until you tell us that nothing relies on the faulty DNS record which is currently in place. As far as I see it doesn't work and it doesn't go through our HTTPS end-point...

I just want to make sure I'm wading in something that did work, by changing DNS records :)

Comment 3

[Jake Watkins [:dividehex]]

I actually tried to set this up before the holiday break but failed to get the ssl endpoint working. The CNAME was then set to the non-ssl endpoint while testing.  Therefore nothing should be pointing at the cname yet

... Proper CNAME is set now and the ssl endpoint is working.  Just need the code change to match and then update org webhooks.

; <<>> DiG 9.9.5-3ubuntu0.6-Ubuntu <<>> github.taskcluster.net +noall +answer
;; global options: +cmd
github.taskcluster.net. 27      IN      CNAME   shizuoka-5876.herokussl.com.
shizuoka-5876.herokussl.com. 3447 IN    CNAME   elb042823-1445896378.us-east-1.elb.amazonaws.com.
elb042823-1445896378.us-east-1.elb.amazonaws.com. 48 IN A 54.243.78.74
elb042823-1445896378.us-east-1.elb.amazonaws.com. 48 IN A 23.23.110.46
elb042823-1445896378.us-east-1.elb.amazonaws.com. 48 IN A 54.197.225.245

Comment 4

[Pete Moore [:pmoore][:pete]]

Attachment: Github Pull Request for taskcluster-github

Comment 5

[Jake Watkins [:dividehex]]

Looks like the TC org webhook for TC-GH also has Commit_Comment, Create and Pull_Request_Review_Comment included as events which are returning resp 400 since they aren't handled.  I'm going to remove these event when I change the url to match the new production url.

Comment 6

[Jake Watkins [:dividehex]]

Taskcluster org webhook has been updated.  Bug has been filed for the Mozilla org to change the webhook URL.  So that leaves just leaves mozilla-services.  I'll contact mreid to make the change.

Comment 7

[Pete Moore [:pmoore][:pete]]

Thanks Jake!

Comment 8

[Jake Watkins [:dividehex]]

All tc-gh consumers have updated their org webhooks.  And I've deployed the baseUrl code change to production.  Calling this r/f

Comment 9

[Pete Moore [:pmoore][:pete]]

Attachment: Github Pull Request for taskcluster-proxy

Enabling github under new domain with taskcluster-proxy...