1237616 - Remove the aForceBuffering arugment from MediaDecoder::Resume()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[JW Wang [:jwwang] [:jw_wang]]

https://hg.mozilla.org/mozilla-central/file/1ec3a3ff68f2d1a54e6ed33e926c28fee286bdf1/dom/html/HTMLMediaElement.cpp#l2187

The only caller of MediaDecoder::Resume(true) is HTMLMediaElement::StopSuspendingAfterFirstFrame(). Since we have prerolling in MDSM to ensure a smooth start of playback, we should be fine without forcing MDSM to enter buffering mode.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

After checking bug 543769, we don't regress http://hacks.mozilla.org/2010/02/an-html5-offline-image-editor-and-uploader-application/ after removing force buffering.

try is also green. https://treeherder.mozilla.org/#/jobs?repo=try&revision=f4606c825f22&selectedJob=15182196

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1237616_remove_force_buffering.patch

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8705503 [details] [diff] [review]
1237616_remove_force_buffering.patch

Review of attachment 8705503 [details] [diff] [review]:
-----------------------------------------------------------------

What could possibly go wrong... ;)

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/587e092b3f39

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/587e092b3f39