Closed Bug 1237616 Opened 5 years ago Closed 5 years ago

Remove the aForceBuffering arugment from MediaDecoder::Resume()

Categories

(Core :: Audio/Video: Playback, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(1 file)

https://hg.mozilla.org/mozilla-central/file/1ec3a3ff68f2d1a54e6ed33e926c28fee286bdf1/dom/html/HTMLMediaElement.cpp#l2187

The only caller of MediaDecoder::Resume(true) is HTMLMediaElement::StopSuspendingAfterFirstFrame(). Since we have prerolling in MDSM to ensure a smooth start of playback, we should be fine without forcing MDSM to enter buffering mode.
Assignee: nobody → jwwang
Blocks: 948267
Attachment #8705503 - Flags: review?(cpearce)
Comment on attachment 8705503 [details] [diff] [review]
1237616_remove_force_buffering.patch

Review of attachment 8705503 [details] [diff] [review]:
-----------------------------------------------------------------

What could possibly go wrong... ;)
Attachment #8705503 - Flags: review?(cpearce) → review+
Priority: -- → P2
Thanks for the review!
https://hg.mozilla.org/mozilla-central/rev/587e092b3f39
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.