1237625 - [testdroid-proxy] Randomize the device being picked up

Status: RESOLVED FIXED

(Taskcluster :: UI, defect)

Description

[Johan Lorenzo [:jlorenzo]]

While investigating bug 1236908, I realized that this test was more intermittent on Taskcluster than it is on Jenkins. 

After looking at the API, the first device returned is the faulty one(356cd0b6).

The Jenkins plugin does the order of device being picked up[1]. I think we just have to do the same in the JS proxy[2].

[1] https://github.com/srautiai/testdroid-marionette-plugin/blob/485bccb4847e6c0b86e129c6b3a91a7a2ec5e004/src/main/java/jenkins/plugins/testdroid/DeviceSessionWrapper.java#L496
[2] https://github.com/taskcluster/testdroid-proxy/blob/7263d8a5ca1dd228ebde79f66054363ee68c03d9/src/handlers/device.js#L177

Comment 1

[Johan Lorenzo [:jlorenzo]]

Attachment: testdroid-proxy PR

I'm not too sure if I should update/add tests in another repo. Please tell me if I should.

Comment 2

[Greg Arndt [:garndt]]

Why is the first one returned faulty? I mean, if 5 devices are returned for the same build, then randomizing which one to use is fine, but what if only 1 is returned? 

I'm curious to know why the one is faulty.  Maybe I'm missing something.

Comment 3

[Johan Lorenzo [:jlorenzo]]

In bug 1236908 comment 5, I realized the 2 SIM cards are swapped (compared to what the config file reads), which makes 1 test fail. Once that tiny maintenance operation is done, that device will work perfectly among the others.

Comment 4

[Greg Arndt [:garndt]]

So if this is going to be fixed by swapping the sims, is this change needed? Or is it just a good thing to have regardless?

Comment 5

[Johan Lorenzo [:jlorenzo]]

I'd say it's good to have it anyway. It would flatten our device-usage. One won't be overly used compared to the others. So we won't require a huge plan on 1 SIM card but nt the others. Every configuration will be similar.

Comment 6

[Greg Arndt [:garndt]]

Comment on attachment 8705151 [details] [review]
testdroid-proxy PR

merged.  Created testdroid-proxy:0.0.7 image and pushed.  Updating worker to use this new image soon.