1237637 - Give an error on negative texture levels

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Attachment: Give an error on negative texture levels

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: 0001-Disallow-negative-levels-for-framebuffer-attachments.patch

Counter-proposal.

Comment 2

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8705165 [details] [diff] [review]
Give an error on negative texture levels

Review of attachment 8705165 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLFramebuffer.cpp
@@ +620,5 @@
>          }
>      }
>  
> +    // We could only check this if (tex), but let's be conservative
> +    if (level < 0) {

This is fine, but I think this check should go near the level != 0 check.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aa57c1fd4a6d

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/aa57c1fd4a6d