Closed Bug 1237637 Opened 5 years ago Closed 5 years ago

Give an error on negative texture levels

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: jrmuizel, Assigned: jgilbert)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attachment #8705165 - Attachment is patch: true
Attachment #8705165 - Flags: review?(jgilbert)
Counter-proposal.
Attachment #8705406 - Flags: review?(jmuizelaar)
Comment on attachment 8705165 [details] [diff] [review]
Give an error on negative texture levels

Review of attachment 8705165 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLFramebuffer.cpp
@@ +620,5 @@
>          }
>      }
>  
> +    // We could only check this if (tex), but let's be conservative
> +    if (level < 0) {

This is fine, but I think this check should go near the level != 0 check.
Attachment #8705165 - Flags: review?(jgilbert) → review+
Attachment #8705406 - Flags: review?(jmuizelaar) → review+
Assignee: nobody → jgilbert
Attachment #8705165 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/aa57c1fd4a6d
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.