1237644 - Unable to switch back to standard Sync server after region/locale change from China

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Aaron Train [:aaronmt]]

An edge-case, but discovered locally.

* Change device to China region and simplified Chinese
* Make sure toggle is set to use the China Sync server
* Switch device to United States region and English

↳ Settings | Sign In | → See the China Region sign-in 

We need to remember to revert back to the standard Sync server

Comment 1

[Aaron Train [:aaronmt]]

This is also reproducible via the 'Show Intro' setting and following through the Sign-In slide.

Comment 2

[DongShengXue]

About the user story, I wander why the user use the  Chinese/China first, and then change the Lang/Region?
For these users, what they really want when they change the Lang/Region? 
1, If user changed the sync setting manually in Chinese/China, we keep the Sync server that user setted.
2, If user have connected to sync server, after disconnected from the server we keep the Sync server that user connected.
3, Other case, we revert back to the standard/China Sync server with Lang/Region.
Is it make sence?

Comment 3

[DongShengXue]

Attachment: Pull request

Comment 4

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I think it is an edge case that we can live with.

So I would prefer to not fix this right now and leave it as is.

Lets talk about a better solution post 1.4.

Comment 5

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8705918 [details] [review]
Pull request

See comments in bug.

Comment 6

[Bingqing Li]

Some updates:
-------------------------------------------------------------------------------------
I tried on v1.4(1404), this issue can be reproduced with the following steps:

1) Set region to China and language to simplified Chinese, then install Firefox for iOS(China Edition)
2) Disable the option for China-hosted Firefox Accounts/Sync service.
3) Enable the option for China-hosted Firefox Accounts/Sync service again.
4) Change the region or/and language to another one.
   e.g. Change the region to US or/and language to English.
5) Tap on "Sign in"
   ==> It will open the sign-in page of China-hosted Firefox Accounts/Sync service.


If you never did step 2) and 3), it is able to switch back to standard Sync server after changing the region/language from China/Simplified Chinese.

Comment 7

[Stephan Leroux [:sleroux]]

Looks like this was addressed in this commit: https://github.com/mozilla/firefox-ios/commit/ebde8f60379c3bd338c3e0153d7f7d6ef7df8073