1237677 - Update OpenTok library to 2.7.2

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P3)

Description

[msander]

Attachment: webrtc-js-2.7.2.tgz

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/47.0.2526.80 Safari/537.36

Comment 1

[msander]

This version of the SDK has extensive refactoring that does not change any of our supported APIs.

Here is a link to the release notes with other changes and known issues:
https://tokbox.com/developer/sdks/js/release-notes.html

Comment 2

[GitHub Autolander Bot]

Attachment: [loop] Standard8:bug-1237677-sdk > mozilla:master

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8709378 [details] [review]
[loop] Standard8:bug-1237677-sdk > mozilla:master

More looking for an rs here. I've done various tests across FF & Chrome and also a few cross-computer ones and it all seems fine.

Comment 4

[Mark Banner (:standard8)]

https://github.com/mozilla/loop/commit/c48ee4f9ecef085d51f7bab957034b524f502b92

Comment 5

[Mark Banner (:standard8)]

I've just backed this out due to the bustage its causing in bug 1248407. We're doing lots of release type things at the moment, so I don't want this accidentally getting released.

https://github.com/mozilla/loop/commit/0256ddfa4a04dbe4090eab598ea485249a134db0

We can try upgrading to the next version once we have a fix for bug 1248407.

Comment 6

[Mark Banner (:standard8)]

Dropping priority until there's a fix about.

Comment 7

[Mark Banner (:standard8)]

Sorry for the noise here. We've found that bug 1248407 is an issue affecting nightly only. I'm not sure how I missed that when I was testing - that issue should be fixed soon.

I've therefore re-landed this onto master:

https://github.com/mozilla/loop/commit/44a274c9a846b7889e83c4249bc57c60ce8c0ba9

Comment 8

[msander]

Attachment: webrtc-js-2.7.3.tgz

Attached v2.7.3 which includes the fix for bug 1186543 along with the other deprecated interfaces with the "moz" prefix. Just want to make sure you are landing the right version. I sent it via email before instead of attaching it here. Sorry.

Comment 9

[Mark Banner (:standard8)]

(In reply to msander from comment #8)
> Created attachment 8724282 [details]
> webrtc-js-2.7.3.tgz
> 
> Attached v2.7.3 which includes the fix for bug 1186543 along with the other
> deprecated interfaces with the "moz" prefix. Just want to make sure you are
> landing the right version. I sent it via email before instead of attaching
> it here. Sorry.

Thanks Mike. I hadn't forgotten I was planning on re-landing 2.7.2 due to the previous issue and then landing 2.7.3. I've just filed bug 1251824 for that which I'll deal with on Monday.