1237694 - Show toolbars when scrolling to the very end of a page

Status: VERIFIED FIXED

(Firefox for iOS :: Browser, defect)

Description

[Richard Newman [:rnewman]]

This is common behavior in apps that have immersive self-hiding toolbars. When you reach the end of the page, there's a good chance you want to share it, save it, go back, or hit the URL bar.

Right now we force you to scroll up a little way to get the bars to come back.

Comment 1

[Nathanael Alcock]

Attachment: Pull request

Comment 2

[Stephan Leroux [:sleroux]]

Comment on attachment 8771440 [details] [review]
Pull request

Code looks good and makes sense. Found a couple of bugs though related to scrolling so the logic might need to be addressed a bit.

Comment 3

[Stephan Leroux [:sleroux]]

Comment on attachment 8771440 [details] [review]
Pull request

Thanks for all of the revisions and work on this patch. I'm always wary of large changes to the scroll controller since its always a pain to get right and is at the forefront of the browser experience. I think this patch is in a good place - simple and addresses the main concern. For any other scrolling issues, feel free to file separate bugs for those issues.

Comment 4

[Stephan Leroux [:sleroux]]

master 4f04495360381f602bc66c755f3ed3a8865ec78c

Comment 5

[Catalin Suciu [:csuciu]]

Verifying as fixed on master 4f0449536. The toolbar is shown when scrolling to the end of the page.