1237770 - Disable D3D9 on XP when E10S is on

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

See bug 1237769.  XP+D3D9+E10S is busted.  Disable D3D9 until this is fixed.

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

Or perhaps a more consistent thing is to disable E10S when D3D9 is on?  Brad, any preferences?

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Should we just disable D3D9 for XP in general?

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

(In reply to Brad Lassey [:blassey] (use needinfo?) from comment #3)
> Should we just disable D3D9 for XP in general?

It may come to that.

D3D9 and XP are fine when E10S is not in the picture, so I wouldn't want to do that until we get to the bottom of this.  It is possible that the problem exists everywhere, and that E10S is just tickling it; it is also possible this is hardware/driver specific - we only have one XP system that can run D3D9, so we're arranging for BetaBreakers to test on another 20 or so configurations.

Comment 5

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: MozReview Request: Bug 1237770: Disable D3D9 on XP with E10S. r?jrmuizel

Review commit: https://reviewboard.mozilla.org/r/30737/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/30737/

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8707505 [details]
MozReview Request: Bug 1237770: Disable D3D9 on XP with E10S. r?jrmuizel

https://reviewboard.mozilla.org/r/30737/#review27613

Comment 7

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8707505 [details]
MozReview Request: Bug 1237770: Disable D3D9 on XP with E10S. r?jrmuizel

https://reviewboard.mozilla.org/r/30737/#review27869

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/269ad7540a30

Comment 9

[William Lachance (:wlach)]

FWIW this has a mostly positive effect on the Talos numbers: https://treeherder.allizom.org/perf.html#/alerts?id=1802&framework=1&hideImprovements=0

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/269ad7540a30

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

there are two small talos regressions (as per comment 9), I assume there is nothing specific left to do here as this id a d3d9 issue.

Comment 12

[Milan Sreckovic [:milan] (needinfo for best results)]

Right - hopefully this is a temporary thing (disabling D3D9 in this scenario) until we fix bug 1237769.

Comment 13

[Brad Lassey [:blassey] (use needinfo?)]

Milan, sounds like we should uplift this to 45 for the e10s beta experiment

Comment 14

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8707505 [details]
MozReview Request: Bug 1237770: Disable D3D9 on XP with E10S. r?jrmuizel

Approval Request Comment
We don't know if E10S and D3D9 on XP ever properly worked, and if it did, on which hardware, so it is safer to disable it and go for the correctness.  Further, we know that E10S/D3D9 combination has performance issues, because we never wrote the optimized path for it, so disabling it will not give us a performance drop (until we fix this performance issue.)
Finally, the "disable D3D9" code path is exercised for blocklisted hardware, so it is not a new one, and the risk should be small.

Comment 15

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8707505 [details]
MozReview Request: Bug 1237770: Disable D3D9 on XP with E10S. r?jrmuizel

OK, let's take it.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/939ba6d07b69