Closed
Bug 1237775
Opened 8 years ago
Closed 8 years ago
Turn off network change monitoring on Linux
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
People
(Reporter: dragana, Assigned: dragana)
References
Details
(Keywords: user-doc-needed)
Attachments
(1 file, 1 obsolete file)
1.16 KB,
patch
|
dragana
:
review+
Sylvestre
:
approval-mozilla-aurora+
ritu
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Because of some problems with network change events on Linux, we will turn it off on beta and aurora. It is only a pref change. On nightly it will left on and will be fixed soon.
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → dd.mozilla
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8705395 -
Flags: review?(mcmanus)
Comment 2•8 years ago
|
||
Comment on attachment 8705395 [details] [diff] [review] bug_1237775.patch Review of attachment 8705395 [details] [diff] [review]: ----------------------------------------------------------------- ::: modules/libpref/init/all.js @@ +1196,5 @@ > pref("network.allow-experiments", true); > > // Allow the network changed event to get sent when a network topology or > // setup change is noticed while running. > +#if defined(XP_UNIX) trailing whitespace nit
Attachment #8705395 -
Flags: review?(mcmanus) → review+
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8705395 -
Attachment is obsolete: true
Attachment #8705704 -
Flags: review+
Assignee | ||
Comment 4•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=69d6d6215e05
Assignee | ||
Comment 5•8 years ago
|
||
Comment on attachment 8705704 [details] [diff] [review] bug_1237775.patch Approval Request Comment [Feature/regressing bug #]: Bug 1191253 [User impact if declined]: This is only Linux bug. For some users ipv6 addresses are refresh often (even every 3-4 seconds) and each refresh firefox wrongly detects as network change event which causes the idle connections to be closed. So if a server takes some time to respond connection will be closed. Bugs: 1234548, 1237583, 1235509, 1238062, 1234751. [Describe test coverage new/current, TreeHerder]: All reporters reported that flipping the pref solves the problem: https://bugzilla.mozilla.org/show_bug.cgi?id=1237583#c2 https://bugzilla.mozilla.org/show_bug.cgi?id=1238062#c3 https://bugzilla.mozilla.org/show_bug.cgi?id=1234548#c13 https://bugzilla.mozilla.org/show_bug.cgi?id=1234548#c18 https://bugzilla.mozilla.org/show_bug.cgi?id=1234548#c20 [Risks and why]: This is only pref change (network.notify.changed set by default to false on linux only) and with this pref change the behaviour will be the same as no ff42. We will fix this problem on the current nightly (ff46) therefore we are not flipping the pref on nightly. [String/UUID change made/needed]: none
Attachment #8705704 -
Flags: approval-mozilla-beta?
Attachment #8705704 -
Flags: approval-mozilla-aurora?
Updated•8 years ago
|
status-firefox44:
--- → affected
status-firefox45:
--- → affected
Comment 7•8 years ago
|
||
Comment on attachment 8705704 [details] [diff] [review] bug_1237775.patch Sure, let's disable it.
Attachment #8705704 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8705704 [details] [diff] [review] bug_1237775.patch Based on the stricter uplift criteria for Beta44, this fits into major regressions bucket. Based on the uplift request this bug seems like something introduced in 43 and we should be trying to fix in 44, at least by turning the pref off. Beta44+
Attachment #8705704 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 10•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-beta/rev/ef3cfadfccb9
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment 11•8 years ago
|
||
Verified as fixed on Firefox for Android 44 Beta 10
Comment 12•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/ef3cfadfccb9
status-b2g-v2.5:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•