Closed
Bug 1237813
Opened 10 years ago
Closed 10 years ago
refactor nsLayoutUtils::FindScrollableFrameFor to use GetScrollFrameFromContent
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: tnikkel, Assigned: tnikkel)
Details
Attachments
(1 file)
|
3.34 KB,
patch
|
botond
:
review+
|
Details | Diff | Splinter Review |
From bug 1194851, comment 49.
|
Assignee | |
Comment 1•10 years ago
|
||
Assignee: nobody → tnikkel
Attachment #8705382 -
Flags: review?(botond)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8705382 [details] [diff] [review]
patch
Review of attachment 8705382 [details] [diff] [review]:
-----------------------------------------------------------------
::: layout/base/nsLayoutUtils.cpp
@@ +774,5 @@
> if (!content) {
> return nullptr;
> }
>
> + nsIFrame* scrolledFrame = GetScrollFrameFromContent(content);
This should probably be called "scrollFrame" rather than "scrolledFrame"?
Attachment #8705382 -
Flags: review?(botond) → review+
|
||
Comment 4•10 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
|
||
Updated•7 years ago
|
Product: Core → Core Graveyard
|
||
Updated•7 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•