Closed Bug 1237813 Opened 8 years ago Closed 8 years ago

refactor nsLayoutUtils::FindScrollableFrameFor to use GetScrollFrameFromContent

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: tnikkel, Assigned: tnikkel)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Assignee: nobody → tnikkel
Attachment #8705382 - Flags: review?(botond)
Comment on attachment 8705382 [details] [diff] [review]
patch

Review of attachment 8705382 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/nsLayoutUtils.cpp
@@ +774,5 @@
>    if (!content) {
>      return nullptr;
>    }
>  
> +  nsIFrame* scrolledFrame = GetScrollFrameFromContent(content);

This should probably be called "scrollFrame" rather than "scrolledFrame"?
Attachment #8705382 - Flags: review?(botond) → review+
https://hg.mozilla.org/mozilla-central/rev/6529572ba56e
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Product: Core → Core Graveyard
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: