Silence linker warnings from MOZ_FOLD_LIBS on Windows

RESOLVED WONTFIX

Status

RESOLVED WONTFIX
3 years ago
8 months ago

People

(Reporter: ted, Assigned: ted)

Tracking

Trunk
mozilla47

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

We get a ton of linker warnings about linking NSPR into NSS because all the NSPR symbols are declspec(dllimport). They were bothering me while working on bug 1230117 so I fixed it.
Created attachment 8707471 [details]
MozReview Request: bug 1237863 - Silence linker errors from MOZ_FOLD_LIBS on Windows. r=glandium

Review commit: https://reviewboard.mozilla.org/r/30721/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/30721/
Attachment #8707471 - Flags: review?(mh+mozilla)
Comment on attachment 8707471 [details]
MozReview Request: bug 1237863 - Silence linker errors from MOZ_FOLD_LIBS on Windows. r=glandium

https://reviewboard.mozilla.org/r/30721/#review27833

::: config/external/nss/Makefile.in:258
(Diff revision 1)
> +MOZ_FOLD_LIBS_FLAGS += -D_NSPR_BUILD_=1

_NSPR_BUILD_ changes the definition of NSPR_API/NSPR_DATA_API to use PR_EXPORT instead of PR_IMPORT. Technically, switching from one to the other only affects windows, because everywhere else, PR_EXPORT and PR_IMPORT are the same thing.

So it seems to me you can remove the OS_TARGET test.
Attachment #8707471 - Flags: review?(mh+mozilla) → review+
Attachment #8707471 - Attachment description: MozReview Request: bug 1237863 - Silence linker errors from MOZ_FOLD_LIBS on Windows. r?glandium → MozReview Request: bug 1237863 - Silence linker errors from MOZ_FOLD_LIBS on Windows. r=glandium
Comment on attachment 8707471 [details]
MozReview Request: bug 1237863 - Silence linker errors from MOZ_FOLD_LIBS on Windows. r=glandium

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/30721/diff/1-2/

Comment 5

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a97ef6f6f50a
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46

Updated

3 years ago
Target Milestone: mozilla46 → mozilla47
Depends on: 1242802
https://hg.mozilla.org/integration/mozilla-inbound/rev/e265e7992928c9ca7bacfd8bfca1929e974b2467
backout bug 1237863 - Silence linker errors from MOZ_FOLD_LIBS on Windows for causing shutdown crashes on Windows (bug 1242802). r=me
I backed this out for causing the crashes in bug 1242802. This doesn't seem worth fixing given that headache. When we tackle fixing NSS' build system we can make this go away.
Resolution: FIXED → WONTFIX
status-firefox46: affected → ---
status-firefox47: fixed → ---

Updated

8 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.