1237863 - Silence linker warnings from MOZ_FOLD_LIBS on Windows

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

We get a ton of linker warnings about linking NSPR into NSS because all the NSPR symbols are declspec(dllimport). They were bothering me while working on bug 1230117 so I fixed it.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: MozReview Request: bug 1237863 - Silence linker errors from MOZ_FOLD_LIBS on Windows. r=glandium

Review commit: https://reviewboard.mozilla.org/r/30721/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/30721/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8707471 [details]
MozReview Request: bug 1237863 - Silence linker errors from MOZ_FOLD_LIBS on Windows. r=glandium

https://reviewboard.mozilla.org/r/30721/#review27833

::: config/external/nss/Makefile.in:258
(Diff revision 1)
> +MOZ_FOLD_LIBS_FLAGS += -D_NSPR_BUILD_=1

_NSPR_BUILD_ changes the definition of NSPR_API/NSPR_DATA_API to use PR_EXPORT instead of PR_IMPORT. Technically, switching from one to the other only affects windows, because everywhere else, PR_EXPORT and PR_IMPORT are the same thing.

So it seems to me you can remove the OS_TARGET test.

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 8707471 [details]
MozReview Request: bug 1237863 - Silence linker errors from MOZ_FOLD_LIBS on Windows. r=glandium

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/30721/diff/1-2/

Comment 4

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a97ef6f6f50acd9fa82d19e4f0d3f5e44c9de757
bug 1237863 - Silence linker errors from MOZ_FOLD_LIBS on Windows. r=glandium

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a97ef6f6f50a

Comment 6

[(not currently active) Ted Mielczarek]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c9613f97f577

Comment 7

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e265e7992928c9ca7bacfd8bfca1929e974b2467
backout bug 1237863 - Silence linker errors from MOZ_FOLD_LIBS on Windows for causing shutdown crashes on Windows (bug 1242802). r=me

Comment 8

[(not currently active) Ted Mielczarek]

I backed this out for causing the crashes in bug 1242802. This doesn't seem worth fixing given that headache. When we tackle fixing NSS' build system we can make this go away.