1237896 - [Gamepad] Button Event cannot be correctly triggered after reconnect

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Michael Leu[:Lenzak](UTC+8)]

Test Environment:
Mac OSX Yosemite 10.10.5 and Stock PS4 controller over USB

Firefox Version
43.0.4 and nightly

Symptom:
In HTML5 gamepad tester (html5gamepad.com) DOM side cannot receive button event from HAL after gamepad is reconnected.

Cause:
CocoaGamepad.cpp passes incorrect gamepad index after any disconnect event

Solution:
Change the first argument NewButtonEvent() and NewAxisEvent() in InputValueChanged() from i to gamepad.mSuperIndex

Patch is ongoing

Comment 1

[Michael Leu[:Lenzak](UTC+8)]

Attachment: Correct gamepad index passing from HAL side

Comment 2

[Michael Leu[:Lenzak](UTC+8)]

I found this bug when I am moving Gamepad IPDL to PBackground.
I think it's a seperate issue, so I filed a new bug.

Comment 3

[Michael Leu[:Lenzak](UTC+8)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=746a4e1d38ec

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/910229c74099

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/910229c74099