interdiff fails totally if previous version removed a file but the next one has it

NEW
Unassigned

Status

MozReview
General
P3
normal
2 years ago
3 months ago

People

(Reporter: smaug, Unassigned)

Tracking

(Blocks: 1 bug)

Details

(Whiteboard: [to be fixed in core])

(Reporter)

Description

2 years ago
https://reviewboard.mozilla.org/r/29831/diff/1-2/

v1 removed file_fullscreen-api-keys.html
v2 has that file with some changes to the original code.
All mozreview tells is that file was deleted.

This might be just a variant of mozreview not dealing with file removes.
This is dataloss and can erode the quality of a review. This should probably be high-priority for fixing.
(In reply to Mike Conley (:mconley) - Needinfo me! from comment #1)
> This is dataloss and can erode the quality of a review. This should probably
> be high-priority for fixing.

Definitely. This is certainly a Review Board core bug around interdiffs, I'll take a look into this.
Assignee: nobody → smacleod
Status: NEW → ASSIGNED
Priority: -- → P1
I've filed a core bug (https://hellosplat.com/s/beanbag/tickets/4052/) for taking care of this.
Whiteboard: [to be fixed in core]
(Assignee)

Updated

2 years ago
Product: Developer Services → MozReview

Updated

2 years ago
Blocks: 1255654
See Also: → bug 1273385

Updated

2 years ago
Priority: P1 → P3
Assignee: smacleod → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.