Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: rail, Assigned: rail)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

3 years ago
We can kill a lot of things:

* av
* permissions
* push to mirrors
* partner repacks stuff
* symlinking
* index.html stuff
* product-details?
(Assignee)

Comment 1

3 years ago
Created attachment 8705791 [details] [diff] [review]
stage-tasks-buildbotcustom.diff

* killed permission check, not applicable anymore
* renamed stage-tasks.py to post-release.sh, no args passed, because post-release is the only action left in that script (patch incoming)
Attachment #8705791 - Flags: review?(bhearsum)
(Assignee)

Comment 2

3 years ago
Created attachment 8705793 [details] [diff] [review]
stage-tasks-tools.diff

* renamed the scripts to post-release.sh/py, couldn't get generate a diff with post-release.py renamed, sorry...

* killed product-details and util.svn, not used
* post-release.py doesn't handle arguments anymore, it's a single purpose script now
* killed AV (Nick ported it to mozharness + S3), check permission (not applicable anymore in S3), push to mirrors (Nick ported it to mozharness + S3)
* removed unused index.html and partner repacks helpers
Attachment #8705793 - Flags: review?(bhearsum)
(Assignee)

Comment 3

3 years ago
Created attachment 8705794 [details] [diff] [review]
stage-tasks-buildbot-configs.diff

Removed unused variables
Attachment #8705794 - Flags: review?(bhearsum)
Comment on attachment 8705794 [details] [diff] [review]
stage-tasks-buildbot-configs.diff

Review of attachment 8705794 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozilla/release-fennec-mozilla-beta.py
@@ -118,5 @@
> -# Product details config
> -releaseConfig["productDetailsRepo"] = "svn+ssh://ffxbld@svn.mozilla.org/libs/product-details"
> -releaseConfig["mozillaComRepo"]     = "svn+ssh://ffxbld@svn.mozilla.org/projects/mozilla.com"
> -releaseConfig["svnSshKey"]          = "/home/cltbld/.ssh/ffxbld_rsa"
> -

Double check with Sylvestre that these are no longer needed before landing, please...I'm pretty sure they're fine to remove though.
Attachment #8705794 - Flags: review?(bhearsum) → review+
Comment on attachment 8705793 [details] [diff] [review]
stage-tasks-tools.diff

Review of attachment 8705793 [details] [diff] [review]:
-----------------------------------------------------------------

r=me on the stage-tasks parts, but double check with Sylvestre about product details/svn sutff.
Attachment #8705793 - Flags: review?(bhearsum) → review+
Attachment #8705791 - Flags: review?(bhearsum) → review+
(Assignee)

Comment 6

3 years ago
Sylvestre,

I'm going to clean up the postrelease tasks here and one of the things that is going away is the old unused script to bump things (PHP files) in SVN. AFAIK, we are going to use ship-it for product details and there is no need to keep this script around.

Am I correct?
Flags: needinfo?(sledru)
Correct, a lot of code which won't ever be used :)
Flags: needinfo?(sledru)
(Assignee)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.