1238083 - Clean up stage tasks

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Rail Aliiev [:rail]]

We can kill a lot of things:

* av
* permissions
* push to mirrors
* partner repacks stuff
* symlinking
* index.html stuff
* product-details?

Comment 1

[Rail Aliiev [:rail]]

Attachment: stage-tasks-buildbotcustom.diff

* killed permission check, not applicable anymore
* renamed stage-tasks.py to post-release.sh, no args passed, because post-release is the only action left in that script (patch incoming)

Comment 2

[Rail Aliiev [:rail]]

Attachment: stage-tasks-tools.diff

* renamed the scripts to post-release.sh/py, couldn't get generate a diff with post-release.py renamed, sorry...

* killed product-details and util.svn, not used
* post-release.py doesn't handle arguments anymore, it's a single purpose script now
* killed AV (Nick ported it to mozharness + S3), check permission (not applicable anymore in S3), push to mirrors (Nick ported it to mozharness + S3)
* removed unused index.html and partner repacks helpers

Comment 3

[Rail Aliiev [:rail]]

Attachment: stage-tasks-buildbot-configs.diff

Removed unused variables

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 8705794 [details] [diff] [review]
stage-tasks-buildbot-configs.diff

Review of attachment 8705794 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozilla/release-fennec-mozilla-beta.py
@@ -118,5 @@
> -# Product details config
> -releaseConfig["productDetailsRepo"] = "svn+ssh://[e-mail]/libs/product-details"
> -releaseConfig["mozillaComRepo"]     = "svn+ssh://[e-mail]/projects/mozilla.com"
> -releaseConfig["svnSshKey"]          = "/home/cltbld/.ssh/ffxbld_rsa"
> -

Double check with Sylvestre that these are no longer needed before landing, please...I'm pretty sure they're fine to remove though.

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 8705793 [details] [diff] [review]
stage-tasks-tools.diff

Review of attachment 8705793 [details] [diff] [review]:
-----------------------------------------------------------------

r=me on the stage-tasks parts, but double check with Sylvestre about product details/svn sutff.

Comment 6

[Rail Aliiev [:rail]]

Sylvestre,

I'm going to clean up the postrelease tasks here and one of the things that is going away is the old unused script to bump things (PHP files) in SVN. AFAIK, we are going to use ship-it for product details and there is no need to keep this script around.

Am I correct?

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Correct, a lot of code which won't ever be used :)

Comment 8

[Rail Aliiev [:rail]]

Comment on attachment 8705791 [details] [diff] [review]
stage-tasks-buildbotcustom.diff

https://hg.mozilla.org/build/buildbotcustom/rev/65c073287d56

Comment 9

[Rail Aliiev [:rail]]

Comment on attachment 8705793 [details] [diff] [review]
stage-tasks-tools.diff

https://hg.mozilla.org/build/tools/rev/323b8322cef5

Comment 10

[Rail Aliiev [:rail]]

Comment on attachment 8705794 [details] [diff] [review]
stage-tasks-buildbot-configs.diff

https://hg.mozilla.org/build/buildbot-configs/rev/0d695ad18d3f

Comment 11

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/0d695ad18d3f

Comment 12

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbotcustom/rev/65c073287d56

Comment 13

[Rail Aliiev [:rail]]

Bustage fix: 

remote:   https://hg.mozilla.org/build/tools/rev/1dee6387de44
remote:   https://hg.mozilla.org/build/tools/rev/bdc0ba7c277c