"Synced Tabs" entry on history panel is shown in a disabled state

VERIFIED FIXED in Firefox 45

Status

()

Firefox
Sync
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: markh, Assigned: markh)

Tracking

unspecified
Firefox 46
Points:
---

Firefox Tracking Flags

(firefox45 verified, firefox46 verified)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Created attachment 8705900 [details] [diff] [review]
0001-Bug-XXXXXXX-Synced-Tabs-entry-on-history-panel-is-al.patch

There is a "Synced Tabs" item on the history panel. This has |disabled="true"| defined in the XUL and while the code correctly manages the hidden state of the item it never removes the disabled attribute. The end result is that the item is correctly hidden when Sync is not configured, but shown and disabled when it is.
Attachment #8705900 - Flags: review?(gijskruitbosch+bugs)
Attachment #8705900 - Flags: review?(gijskruitbosch+bugs) → review+

Comment 1

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/55d6be76fac9
(Assignee)

Comment 2

2 years ago
Comment on attachment 8705900 [details] [diff] [review]
0001-Bug-XXXXXXX-Synced-Tabs-entry-on-history-panel-is-al.patch

Approval Request Comment
[Feature/regressing bug #]: Synced Tabs Panel UI
[User impact if declined]: "Synced Tabs" on the history panel will be disabled for Sync users.
[Describe test coverage new/current, TreeHerder]: Existing tests pass.
[Risks and why]: Trivial 1 line patch
[String/UUID change made/needed]: None
Attachment #8705900 - Flags: approval-mozilla-aurora?

Comment 3

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/55d6be76fac9
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Assignee: nobody → markh
status-firefox45: --- → affected
Attachment #8705900 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 4

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/62a772079ed9
status-firefox45: affected → fixed
Flags: qe-verify+
I was able to reproduce this issue on Firefox 46.0a1 (2016-01-08) under Windows 10 64-bit.

Verified fixed on Firefox 46.0a1 (2016-01-13/14) and Firefox 45.0a2 (2016-01-14) using Windows 10 64-bit, Ubuntu 14.04 32-bit and Mac OS X 10.10.5.
Status: RESOLVED → VERIFIED
status-firefox45: fixed → verified
status-firefox46: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.