Closed Bug 1238187 Opened 4 years ago Closed 4 years ago
"Synced Tabs" entry on history panel is shown in a disabled state
There is a "Synced Tabs" item on the history panel. This has |disabled="true"| defined in the XUL and while the code correctly manages the hidden state of the item it never removes the disabled attribute. The end result is that the item is correctly hidden when Sync is not configured, but shown and disabled when it is.
Attachment #8705900 - Flags: review?(gijskruitbosch+bugs)
Attachment #8705900 - Flags: review?(gijskruitbosch+bugs) → review+
Comment on attachment 8705900 [details] [diff] [review] 0001-Bug-XXXXXXX-Synced-Tabs-entry-on-history-panel-is-al.patch Approval Request Comment [Feature/regressing bug #]: Synced Tabs Panel UI [User impact if declined]: "Synced Tabs" on the history panel will be disabled for Sync users. [Describe test coverage new/current, TreeHerder]: Existing tests pass. [Risks and why]: Trivial 1 line patch [String/UUID change made/needed]: None
Attachment #8705900 - Flags: approval-mozilla-aurora?
Attachment #8705900 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
I was able to reproduce this issue on Firefox 46.0a1 (2016-01-08) under Windows 10 64-bit. Verified fixed on Firefox 46.0a1 (2016-01-13/14) and Firefox 45.0a2 (2016-01-14) using Windows 10 64-bit, Ubuntu 14.04 32-bit and Mac OS X 10.10.5.
You need to log in before you can comment on or make changes to this bug.