1238190 - Follow-up reviews in MozReview are hard (doesn't show which diffs I've already reviewed). Can lead to missed code.

Status: RESOLVED DUPLICATE of bug 1244884

(MozReview Graveyard :: General, defect)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

STR:
1. Go to Bug 1208371 comment 361 from me. Here I have 12 review requests.
2. Try to determine which interdiff #s I need to review for each of the 12 patches
   (My last review here is from around Bug 1208371 comment 205).

I've spent over half an hour now determining which diff versions (I think it's 2-5? though maybe they vary by patch?) that I need to be reviewing. It might help if MozReview kept track of the last diffs I've reviewed, or maybe showed associated dates for the various numeric (1,2,3,4,5 etc.) "revisions"...?

I gather the interdiff links that are auto-posted to bugzilla are meant to help, but here they're actually trouble, because had I followed them I would have r+'ed based solely on the last interdiff, missing lots of code!

The other problem with the interdiff links is that they're in bugzilla rather than in mozReview itself.

It seems to me that mozReview has all the information it needs to present exactly what I need to review.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I had the same problem today and found bug 1296672 which might help here.

Comment 2

[Steven MacLeod [:smacleod]]

Duping to older since it was fixed there.