1238213 - Make FetchEvent.request non-nullable

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[(no longer active)]

It seems that the spec has changed now to make |request| a required init member, so it is non-nullable now.

Comment 1

[(no longer active)]

Attachment: Make FetchEvent.request non-nullable

Comment 2

[Andrea Marchesini [:baku]]

Comment on attachment 8705931 [details] [diff] [review]
Make FetchEvent.request non-nullable

Review of attachment 8705931 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/webidl/FetchEvent.webidl
@@ +10,5 @@
>  [Constructor(DOMString type, optional FetchEventInit eventInitDict),
>   Func="mozilla::dom::workers::ServiceWorkerVisible",
>   Exposed=(ServiceWorker)]
>  interface FetchEvent : ExtendableEvent {
> +  [SameObject] readonly attribute Request request;

Do we still need [SameObject] ?

::: dom/workers/test/serviceworkers/fetch_event_worker.js
@@ +297,5 @@
> +    try {
> +      new FetchEvent("foo");
> +    } catch(e) {
> +      if (e.name == "TypeError") {
> +        dump("XXXehsan " + e + "\n" + e.name + "\n");

dump?

Comment 3

[(no longer active)]

(In reply to Andrea Marchesini (:baku) from comment #2)
> Comment on attachment 8705931 [details] [diff] [review]
> Make FetchEvent.request non-nullable
> 
> Review of attachment 8705931 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/webidl/FetchEvent.webidl
> @@ +10,5 @@
> >  [Constructor(DOMString type, optional FetchEventInit eventInitDict),
> >   Func="mozilla::dom::workers::ServiceWorkerVisible",
> >   Exposed=(ServiceWorker)]
> >  interface FetchEvent : ExtendableEvent {
> > +  [SameObject] readonly attribute Request request;
> 
> Do we still need [SameObject] ?

Yes.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f372ff2c6518

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3bbaa0504a64

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f372ff2c6518
https://hg.mozilla.org/mozilla-central/rev/3bbaa0504a64

Comment 7

[Chris Mills [:cmills]]

I've added a note about this to the request doc:

https://developer.mozilla.org/en-US/docs/Web/API/FetchEvent/request

And a note to the Gecko 46 release notes:

https://developer.mozilla.org/en-US/Firefox/Releases/46#Service_Workers

Let me know if this is ok.