Closed Bug 1238266 Opened 8 years ago Closed 8 years ago

Move hidefor attribute from IDLE checkbox to surrounding vbox

Categories

(MailNews Core :: Account Manager, defect)

Product:
MailNews Core
Component:
Account Manager
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(thunderbird45 fixed, thunderbird46 fixed, seamonkey2.42 fixed, seamonkey2.43 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 46.0
Tracking Flags:
Tracking Status
thunderbird45 --- fixed
thunderbird46 --- fixed
seamonkey2.42 --- fixed
seamonkey2.43 --- fixed

People

(Reporter: rsx11m.pub, Assigned: rsx11m.pub)

References

Details

Attachments

(1 file)

Simple patch
1.33 KB, patch
aceman
: review+
mkmelin
: approval-comm-aurora+
Details | Diff | Splinter Review 
+++ This bug was initially created as a clone of Bug #449021 +++

A minor issue as checked in: the checkbox is hidden for "pop3,nntp,movemail" whereas the vbox around it isn't and just remains empty for non-IMAP accounts.
Attached patch Simple patch — — Splinter Review 
This fixes it and makes the new checkbox consistent with others of its kind.
Assignee: nobody → rsx11m.pub
Status: NEW → ASSIGNED
Attachment #8706011 - Flags: review?(mkmelin+mozilla)
Comment on attachment 8706011 [details] [diff] [review]
Simple patch

Review of attachment 8706011 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the catch. The box is empty and not really visible. But hiding it explicitly should be more correct and consistent.
Attachment #8706011 - Flags: review?(mkmelin+mozilla) → review+
Thanks for the quick review, push for comm-central please.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/7d3bbbb0449d26ef18c9b7a594cbefedf7d616d3
Bug 1238266 - Move hidefor attribute from IDLE checkbox to surrounding vbox. r=aceman
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 46.0
Comment on attachment 8706011 [details] [diff] [review]
Simple patch

[Approval Request Comment]
Regression caused by (bug #): Bug 449021
User impact if declined: no visible effect
Testing completed (on c-c, etc.): works fine on a TB 45.0a2 build
Risk to taking this patch (and alternatives if risky): very low
Attachment #8706011 - Flags: approval-comm-aurora?
Attachment #8706011 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: