1238286 - Searchbar placed in Australis Menu doesn't detect search plugins if Menu wasn't opened in the window

Status: RESOLVED FIXED

(Firefox :: Search, defect, P5)

Description

[arni2033]

Attachment: testcase 1 - five search engines.html

>>>   My Info:   Win7_64, Nightly 46, 32bit, ID 20160107030235
STR:
0. Right-click Searchbar, click "Move to Menu"
1. Copy the link to attached "testcase 1"
2.A) Open new window, paste the link copied in Step 1 into Urlbar, press Enter
2.B) Simply Shift+Click link to "testcase 1" to open in in a new window
3. Click Australis Menu button (≡), click magnifier icon in Searchbar
4.A) Open new tab, paste the link copied in Step 1 into Urlbar, press Enter
4.B) Ctrl+Click or Middle-click reload button
5. Click Australis Menu button (≡), click magnifier icon in Searchbar

Result:       
 After Step 3 searchbar haven't detected any search plugins
 After Step 5 searchbar detected all five search providers

Expectations: 
 After Step 3 searchbar should detect all five providers

This looks like a general issue with Menu (see bug 1231465). I believe extensions are also affected.

Comment 1

[:shell escalante]

Hi Arni, The reproduction steps are rather hard to follow =].  I really appreciate all the bugs you do file.  Is there any chance you could screen shot (if it's clear in one photo what the issue is) or video if you only see with multiple steps?

Comment 2

[arni2033]

(In reply to :shell escalante from comment #1)
Yes, I recently discovered that most of my STR are too complicated.

STR_1_simplified:
1. Move Searchbar to Australis Menu (≡)
2. Shift-click this link:  attachment 8706028 [details]  (to open it in a new window)
3. Open Australis Menu in that window

AR:  Searchbar hasn't detected search engines: no green "Plus" button
ER:  Searchbar should detect all 5 search enhines
> https://dl.dropboxusercontent.com/s/metgy8zl0zgr4jr/bug%201238286%20comment%202.webm?dl=0

Comment 3

[Florian Quèze [:florian]]

Attachment: Patch

- removing the !searchBar.textbox test in updateOpenSearchBadge is just dead code removal. Before http://hg.mozilla.org/mozilla-central/diff/d808114269ad/browser/base/content/browser.js#l1.26 it was a test for searchBar.searchButton, which historically made sense (http://hg.mozilla.org/mozilla-central/rev/7fe80c3c0f1c#l1.34) but has been useless for a while, as setting DOM attributes on the node before the binding is attached is harmless.

- the removed !this.searchBar check in addEngine is to ensure gBrowser.selectedBrowser.engines is populated even when no searchbar exists in the document yet (when the searchbar is in the Australis menu, the searchbar element is only created at the time the menu is first opened).

- the actual fix is calling BrowserSearch.updateOpenSearchBadge from the constructor of the searchbar binding (this makes the (+) badge appear when the Australis menu is first opened, or when the searchbar is moved from the menu back to the toolbar, without waiting for another page load). This depends on gBrowser.selectedBrowser.engines being correctly populated.

Comment 4

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/fx-team/rev/1d5b01d01df634f2113a6ebfd597feb8b70f001f
Bug 1238286 - Searchbar placed in Australis Menu doesn't detect search plugins if Menu wasn't opened in the window, r=adw.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out for test failures:

https://hg.mozilla.org/integration/fx-team/rev/1801b99994e4

https://treeherder.mozilla.org/logviewer.html#?job_id=8575041&repo=fx-team

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Also failing in https://treeherder.mozilla.org/logviewer.html#?job_id=8574388&repo=fx-team

Comment 7

[Florian Quèze [:florian]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c85dbd3e1b80

Comment 8

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/fx-team/rev/82517993e1ccf54ad179e21b35553f7c7e31be5f
Bug 1238286 - Searchbar placed in Australis Menu doesn't detect search plugins if Menu wasn't opened in the window, r=adw.

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/82517993e1cc