cppunittests do not look up breakpad symbols for logged stack traces

RESOLVED FIXED in Firefox 68

Status

defect
RESOLVED FIXED
4 years ago
Last month

People

(Reporter: aklotz, Assigned: aklotz, NeedInfo)

Tracking

Trunk
mozilla68
Unspecified
Windows
Points:
---

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

4 years ago
I'm seeing situations like this:
https://treeherder.mozilla.org/logviewer.html#?job_id=3036257&repo=mozilla-central#L5518

We've hit an assertion but the logged call stack is of limited utility (without a lot of tedious manual intervention) due to lack of symbolication. We have the breakpad symbols for the build, but MozDescribeCodeAddress uses debughlp which groks pdb. If pdbs aren't around, we're not going to get much out of it.

I'm not sure what the best way forward is. Does breakpad have some kind of facility to act as a MS symbol server? Or do we need to add breakpad .sym parsing to MozDescribeCodeAddress?
Assignee

Comment 1

4 years ago
(In reply to Aaron Klotz [:aklotz] (please use needinfo) from comment #0)
> I'm not sure what the best way forward is. Does breakpad have some kind of
> facility to act as a MS symbol server? Or do we need to add breakpad .sym
> parsing to MozDescribeCodeAddress?
Flags: needinfo?(ted)
Assignee

Comment 2

4 years ago
(This also makes debugging in mozharness test environments more difficult, so I'd suggest that a symbol server option is probably more preferable than just modifying MozDescribeCodeAddress).
Assignee

Updated

4 years ago
Component: XPCOM → General
Product: Core → Testing
Version: 43 Branch → Trunk
Assignee

Updated

4 years ago
Summary: nsTraceRefcnt::WalkTheStack output is not useful on Windows without pdbs → cppunittests do not look up breakpad symbols for logged stack traces
Assignee

Comment 4

4 years ago
Posted patch PatchSplinter Review
Locally on mach and on try by looking at the stacks in the assertions on this try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=75bf5d41f88e
Assignee: nobody → aklotz
Status: NEW → ASSIGNED
Attachment #8709133 - Flags: review?(ted)
Comment on attachment 8709133 [details] [diff] [review]
Patch

Review of attachment 8709133 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this!
Attachment #8709133 - Flags: review?(ted) → review+
Assignee

Comment 10

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c32452df00e86d86e65b5097ea253f488816067
Bug 1238305: Modify cppunittests to look up breakpad symbols for logged stack traces; r=ted
Component: General → CPPUnitTest
Assignee

Updated

4 months ago
Blocks: 1493448
Assignee

Updated

4 months ago
No longer blocks: 1493448
Assignee

Comment 14

2 months ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/63bc837753d653ab13635e432400c1b6d31d12ca
Bug 1238305: Modify cppunittests to look up breakpad symbols for logged stack traces; r=ted

Comment 15

2 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
No longer regressed by: 1550419
You need to log in before you can comment on or make changes to this bug.