Closed Bug 1238305 Opened 4 years ago Closed 1 year ago

cppunittests do not look up breakpad symbols for logged stack traces

Categories

(Testing :: CPPUnitTest, defect)

Unspecified
Windows
defect
Not set
normal

Tracking

(firefox68 fixed)

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: aklotz, Assigned: aklotz)

Details

Attachments

(1 file)

I'm seeing situations like this:
https://treeherder.mozilla.org/logviewer.html#?job_id=3036257&repo=mozilla-central#L5518

We've hit an assertion but the logged call stack is of limited utility (without a lot of tedious manual intervention) due to lack of symbolication. We have the breakpad symbols for the build, but MozDescribeCodeAddress uses debughlp which groks pdb. If pdbs aren't around, we're not going to get much out of it.

I'm not sure what the best way forward is. Does breakpad have some kind of facility to act as a MS symbol server? Or do we need to add breakpad .sym parsing to MozDescribeCodeAddress?
(In reply to Aaron Klotz [:aklotz] (please use needinfo) from comment #0)
> I'm not sure what the best way forward is. Does breakpad have some kind of
> facility to act as a MS symbol server? Or do we need to add breakpad .sym
> parsing to MozDescribeCodeAddress?
Flags: needinfo?(ted)
(This also makes debugging in mozharness test environments more difficult, so I'd suggest that a symbol server option is probably more preferable than just modifying MozDescribeCodeAddress).
Component: XPCOM → General
Product: Core → Testing
Version: 43 Branch → Trunk
Summary: nsTraceRefcnt::WalkTheStack output is not useful on Windows without pdbs → cppunittests do not look up breakpad symbols for logged stack traces
Attached patch PatchSplinter Review
Locally on mach and on try by looking at the stacks in the assertions on this try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=75bf5d41f88e
Assignee: nobody → aklotz
Status: NEW → ASSIGNED
Attachment #8709133 - Flags: review?(ted)
Comment on attachment 8709133 [details] [diff] [review]
Patch

Review of attachment 8709133 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing this!
Attachment #8709133 - Flags: review?(ted) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c32452df00e86d86e65b5097ea253f488816067
Bug 1238305: Modify cppunittests to look up breakpad symbols for logged stack traces; r=ted
Component: General → CPPUnitTest
Blocks: 1493448
No longer blocks: 1493448
https://hg.mozilla.org/integration/mozilla-inbound/rev/63bc837753d653ab13635e432400c1b6d31d12ca
Bug 1238305: Modify cppunittests to look up breakpad symbols for logged stack traces; r=ted
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
No longer regressed by: 1550419
Flags: needinfo?(aklotz)
You need to log in before you can comment on or make changes to this bug.