Closed
Bug 1238432
Opened 10 years ago
Closed 10 years ago
We're currently updating the jobs tables twice when the user changes filtering settings
Categories
(Tree Management :: Treeherder, defect)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wlach, Assigned: wlach)
Details
Attachments
(1 file)
Once when the actual event gets fired, once when the location in the URL bar changes. This is obviously silly, and makes what's a frustratingly longer operation even longer.
|
||
Comment 1•10 years ago
|
||
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8706199 [details] [review]
[treeherder] wlach:1238432 > mozilla:master
Easiest performance win ever! :)
Attachment #8706199 -
Flags: review?(cdawson)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8706199 [details] [review]
[treeherder] wlach:1238432 > mozilla:master
Sheesh, my bad... Thanks for catching this! :)
Attachment #8706199 -
Flags: review?(cdawson) → review+
|
|
||
Comment 4•10 years ago
|
||
Pull request has landed in master: https://github.com/mozilla/treeherder/commit/47784bbcbf8ab38e5d050e05032f068830d6918b
|
||
Comment 5•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/2007e8470b714925ac2cb65d1780d50602fdc2fa
Bug 1238432 - Only update job tables once when filtering settings change
https://github.com/mozilla/treeherder/commit/47784bbcbf8ab38e5d050e05032f068830d6918b
Merge pull request #1239 from wlach/1238432
|
|
||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•