1238464 - [emulator-x86-kk][mochitest] TEST-UNEXPECTED-FAIL | gfx/layers/apz/test/mochitest/test_basic_pan.html | Test timed out.

Status: RESOLVED FIXED

(Testing :: Mochitest, defect, P1)

Description

[Hsin-Yi Tsai (she/her) [:hsinyi]]

See mochitest chunk 44 https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=048b60ee7fdd&exclusion_profile=false&selectedJob=3719233

log: https://treeherder.mozilla.org/logviewer.html#?job_id=3719233&repo=b2g-inbound

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Blanket gfx-noted on APZ intermittent failures so they can be found more easily on https://brasstacks.mozilla.com/orangefactor/

Comment 2

[Peter Chang[:pchang]]

Add need info myself to check.

Comment 3

[Peter Chang[:pchang]]

Jerry, please help to check apz failed on emulator-KK.

Comment 4

[Peter Chang[:pchang]]

(In reply to peter chang[:pchang][:peter] from comment #3)
> Jerry, please help to check apz failed on emulator-KK.

Correct the testing platform, please check apz test case on emulator-x86-kk.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Jerry, assign this to me if you'd like me to look into this. I can reproduce it locally and it should be easy for me to track down.

Comment 6

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Hi kats,
I would like to trace this problem at next Monday. If I have any problem, I will tell you soon.

For my first look, the problem is that, the test doesn't receive the "APZ:TransformEnd" and then we get timeout. So I will have some log to check this event passing.

Comment 7

[Jerry Shih[:jerry] (UTC+8) (inactive)]

I think I find the test failed reason. When the mochitest start, we turn the display and start the tests. Then the display is turned off due to the display-off timeout. The compositor will skip all task when the display off. So, the "APZ:TransformEnd" event is never sent.
I'm trying to change the display-off timeout value and test again.

Comment 8

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: Turn on the display before testing.

System app has 10s timeout setting for display. When the display off, all composition tasks will be skip. Then, apz test becomes failed.

Comment 9

[Jerry Shih[:jerry] (UTC+8) (inactive)]

oops, the test still have timeout, but I can pass the test with attachment 8712019 [details] [diff] [review] locally.
try:
https://treeherder.allizom.org/#/jobs?repo=try&revision=963efe12f751&selectedJob=16485893

I will check the compositor status again tomorrow.

Comment 10

[Jerry Shih[:jerry] (UTC+8) (inactive)]

There is no waiting for setting ready in attachment 8712019 [details] [diff] [review], so the apz test might still test with display off. Will have another try for this problem.

Comment 11

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: turn on the display during testing. v2

Comment 12

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: turn on the display during testing. v3

Comment 13

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Comment on attachment 8712654 [details] [diff] [review]
turn on the display during testing. v3

Review of attachment 8712654 [details] [diff] [review]:
-----------------------------------------------------------------

When the device up, we turn on the display and start the tests. Then the display is turned off because of the display-off timeout. The compositor will skip all task when the display off, then some tests will failed.

::: testing/mochitest/b2g_start_script.js
@@ +81,5 @@
>      container.setVisible(true);
>    }
>  });
>  
> +function StartTest() {

Put all code into a StartTest() function

@@ +172,5 @@
> +}
> +settingResult.onerror = function () {
> +  dump("Change screen.time failed");
> +  StartTest();
> +}

Turn on the display using "navigator.mozPower.screenEnabled" and update the timeout setting.
After after setting was done, start the test.

Comment 14

[Jerry Shih[:jerry] (UTC+8) (inactive)]

try result:
https://treeherder.allizom.org/#/jobs?repo=try&revision=00494c387c84
The mochitest chunk 44 is green.

Comment 15

[Andrew Halberstadt [:ahal]]

Comment on attachment 8712654 [details] [diff] [review]
turn on the display during testing. v3

Review of attachment 8712654 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good with the comment addressed.

::: testing/mochitest/b2g_start_script.js
@@ +166,5 @@
> +var settingResult = settingLock.set({
> +  'screen.timeout': 0
> +});
> +settingResult.onsuccess = function () {
> +  dump("Set screen.time to 0");

These dumps need a newline at the end.

Comment 16

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: turn on the display during testing. v4, r=ahal

add newline in dump

Comment 17

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Please land the attachment 8712991 [details] [diff] [review] to m-c

try result:
https://treeherder.allizom.org/#/jobs?repo=try&revision=00494c387c84

Comment 19

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/364cbb21094e

Comment 20

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/364cbb21094e