Closed
Bug 1238467
Opened 8 years ago
Closed 8 years ago
Group checkbox tooltip displays 'undefined' in debugger events panel
Categories
(DevTools :: Debugger, defect)
DevTools
Debugger
Tracking
(firefox46 fixed)
RESOLVED
FIXED
Firefox 46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
Details
Attachments
(2 files, 1 obsolete file)
23.20 KB,
image/png
|
Details | |
5.57 KB,
patch
|
jdescottes
:
review+
|
Details | Diff | Splinter Review |
STRs : - go to any page using event listeners (e.g https://developer.mozilla.org/en-US/) - open the debugger - open the events panel - hover on an event group checkbox Actual : "undefined" is displayed as tooltip Expected : a relevant tooltip should be displayed
Assignee | ||
Updated•8 years ago
|
Component: Developer Tools → Developer Tools: Debugger
Assignee | ||
Comment 1•8 years ago
|
||
For group checkboxes of SideMenuWidget.jsm, we end up doing setAttribute("tooltiptext", undefined) (https://dxr.mozilla.org/mozilla-central/source/devtools/client/shared/widgets/SideMenuWidget.jsm#688) At least we should default to empty string if `aOptions.checkboxTooltip` is falsy. Optionally we can define a default localized tooltiptext for all group checkboxes. Also modified an existing mochitest to check the tooltiptext of the group checkboxes is no longer "undefined". @Victor : Let me know how much of this you think is worth committing/landing.
Comment 2•8 years ago
|
||
Comment on attachment 8707538 [details] [diff] [review] add-tooltiptext.diff Review of attachment 8707538 [details] [diff] [review]: ----------------------------------------------------------------- Very nice
Attachment #8707538 -
Flags: review+
Attachment #8707538 -
Flags: feedback?(vporof)
Attachment #8707538 -
Flags: feedback+
Comment 3•8 years ago
|
||
Ship it
Assignee | ||
Comment 4•8 years ago
|
||
Thanks for the review! Try push ongoing : https://treeherder.mozilla.org/#/jobs?repo=try&revision=f967fa83ccd5
Assignee | ||
Comment 5•8 years ago
|
||
Update commit message with ;r=vporof Carry over r+ from previous patch.
Attachment #8707538 -
Attachment is obsolete: true
Attachment #8707787 -
Flags: review+
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4a2537c6614b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Comment 9•8 years ago
|
||
[bugday-20160323] Status: RESOLVED,FIXED -> VERIFIED Comments: Test Successful STR: clear. Component: Name Firefox Version 46.0b9 Build ID 20160322075646 Update Channel beta User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0 OS Windows 7 SP1 x86_64 Expected Results: msg after hovering on checkbox in event "Tooltip breaking on this event" Actual Results: As expected
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•