Group checkbox tooltip displays 'undefined' in debugger events panel

RESOLVED FIXED in Firefox 46

Status

--
minor
RESOLVED FIXED
3 years ago
9 months ago

People

(Reporter: jdescottes, Assigned: jdescottes)

Tracking

unspecified
Firefox 46

Firefox Tracking Flags

(firefox46 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

3 years ago
STRs : 
- go to any page using event listeners (e.g https://developer.mozilla.org/en-US/)
- open the debugger
- open the events panel
- hover on an event group checkbox

Actual : "undefined" is displayed as tooltip
Expected : a relevant tooltip should be displayed
(Assignee)

Updated

3 years ago
Component: Developer Tools → Developer Tools: Debugger
(Assignee)

Comment 1

3 years ago
Posted patch add-tooltiptext.diff (obsolete) — Splinter Review
For group checkboxes of SideMenuWidget.jsm, we end up doing  setAttribute("tooltiptext", undefined) (https://dxr.mozilla.org/mozilla-central/source/devtools/client/shared/widgets/SideMenuWidget.jsm#688)

At least we should default to empty string if `aOptions.checkboxTooltip` is falsy. Optionally we can define a default localized tooltiptext for all group checkboxes.

Also modified an existing mochitest to check the tooltiptext of the group checkboxes is no longer "undefined".

@Victor : Let me know how much of this you think is worth committing/landing.
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Attachment #8707538 - Flags: feedback?(vporof)
Comment on attachment 8707538 [details] [diff] [review]
add-tooltiptext.diff

Review of attachment 8707538 [details] [diff] [review]:
-----------------------------------------------------------------

Very nice
Attachment #8707538 - Flags: review+
Attachment #8707538 - Flags: feedback?(vporof)
Attachment #8707538 - Flags: feedback+
Ship it
(Assignee)

Comment 5

3 years ago
Update commit message with ;r=vporof
Carry over r+ from previous patch.
Attachment #8707538 - Attachment is obsolete: true
Attachment #8707787 - Flags: review+
(Assignee)

Comment 6

3 years ago
Try push OK, adding checking-needed.
Keywords: checkin-needed

Comment 8

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4a2537c6614b
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46

Comment 9

3 years ago
[bugday-20160323]

Status: RESOLVED,FIXED -> VERIFIED

Comments: Test Successful
STR: clear.


Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
msg after hovering on checkbox in event "Tooltip breaking on this event"

Actual Results: 
As expected

Updated

9 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.