1238467 - Group checkbox tooltip displays 'undefined' in debugger events panel

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Julian Descottes [:jdescottes]]

Attachment: undefined tooltip.png

STRs : 
- go to any page using event listeners (e.g https://developer.mozilla.org/en-US/)
- open the debugger
- open the events panel
- hover on an event group checkbox

Actual : "undefined" is displayed as tooltip
Expected : a relevant tooltip should be displayed

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: add-tooltiptext.diff

For group checkboxes of SideMenuWidget.jsm, we end up doing  setAttribute("tooltiptext", undefined) (https://dxr.mozilla.org/mozilla-central/source/devtools/client/shared/widgets/SideMenuWidget.jsm#688)

At least we should default to empty string if `aOptions.checkboxTooltip` is falsy. Optionally we can define a default localized tooltiptext for all group checkboxes.

Also modified an existing mochitest to check the tooltiptext of the group checkboxes is no longer "undefined".

@Victor : Let me know how much of this you think is worth committing/landing.

Comment 2

[Victor Porof [:vporof][:vp]]

Comment on attachment 8707538 [details] [diff] [review]
add-tooltiptext.diff

Review of attachment 8707538 [details] [diff] [review]:
-----------------------------------------------------------------

Very nice

Comment 3

[Victor Porof [:vporof][:vp]]

Ship it

Comment 4

[Julian Descottes [:jdescottes]]

Thanks for the review! Try push ongoing : https://treeherder.mozilla.org/#/jobs?repo=try&revision=f967fa83ccd5

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: add-tooltiptext.v2.patch

Update commit message with ;r=vporof
Carry over r+ from previous patch.

Comment 6

[Julian Descottes [:jdescottes]]

Try push OK, adding checking-needed.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/4a2537c6614b

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4a2537c6614b

Comment 9

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> VERIFIED

Comments: Test Successful
STR: clear.


Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
msg after hovering on checkbox in event "Tooltip breaking on this event"

Actual Results: 
As expected