1238588 - DownloadContentBootstrap: Use generated IDs

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Currently the static catalog in DownloadContentBootstrap uses randomized IDs. Let's use generated IDs so that we'll continue to use the same IDs when switching to the online catalog backed by Kinto.

From Mathieu:

>>> import uuid
>>> import hashlib
>>> filename = "CharisSILCompact-B.ttf"
>>> identifier = hashlib.md5(filename).hexdigest()
>>> record_id = uuid.UUID(identifier)
>>> record_id
> 'c40929cf-7f4c-fa72-3dc9-12cadf56905d'

IDs:

> CharisSILCompact-B.ttf c40929cf-7f4c-fa72-3dc9-12cadf56905d
> CharisSILCompact-BI.ttf 6d265876-85ed-0917-fdc8-baf583ca2cba
> CharisSILCompact-I.ttf 8460dc6d-d129-fd1a-24b6-343dbf6531dd
> CharisSILCompact-R.ttf c906275c-3747-fe27-426f-6187526a6f06
> ClearSans-Bold.ttf ff5deecc-6ecc-d816-bb51-65face460119
> ClearSans-BoldItalic.ttf a173d1db-373b-ce42-1335-6b3285cfdebd
> ClearSans-Italic.ttf e65c66df-0088-940d-ca5c-207c22118c0e
> ClearSans-Light.ttf 25610abb-5dc8-fd75-40e7-990507f010c4
> ClearSans-Medium.ttf ffe40339-a096-2262-c3f8-54af75c81fe6
> ClearSans-MediumItalic.ttf 139a94be-ac69-0264-c9cc-8f2d071fd29d
> ClearSans-Regular.ttf b887012a-01e1-7c94-fdcb-ca44d5b974a2
> ClearSans-Thin.ttf c8703652-d317-0356-0bf8-95441a5b2c9b

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1238588 - DownloadContentBootstrap: Use generated IDs. r?rnewman,mathieu

Review commit: https://reviewboard.mozilla.org/r/30361/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/30361/

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 8706517 [details]
MozReview Request: Bug 1238588 - DownloadContentBootstrap: Use generated IDs. r?rnewman,mathieu

https://reviewboard.mozilla.org/r/30361/#review27075

Did I not already rubberstamp this already? :)

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/2f7239cd52bae11012cb4ce596b6577cbfe32a3a
Bug 1238588 - DownloadContentBootstrap: Use generated IDs. r=rnewman,mathieu

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2f7239cd52ba