1238723 - tab child needs to use default user context id when handling permissions.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Dave Huseby [:huseby]]

in the file dom/ipc/ContentChild.cpp there's code for creating a principal when handling an add permission message:

> 2413     nsAutoCString originNoSuffix;
> 2414     PrincipalOriginAttributes attrs;
> 2415     attrs.PopulateFromOrigin(permission.origin, originNoSuffix);
> 2416
> 2417     nsCOMPtr<nsIURI> uri;
> 2418     nsresult rv = NS_NewURI(getter_AddRefs(uri), originNoSuffix);
> 2419     NS_ENSURE_SUCCESS(rv, true);
> 2420
> 2421     nsCOMPtr<nsIPrincipal> principal = mozilla::BasePrincipal::CreateCodebasePrincipal(uri, attrs);

because this is dealing with a permission, we need to change the PrincipalOriginAttribute object to a DefaultContextOriginAttributes object to force the user context to the default one.

Comment 1

[Dave Huseby [:huseby]]

This appears to work correctly.

Comment 2

[Dave Huseby [:huseby]]

Going to reopen to add some asserts in here just in case.

Comment 3

[Dave Huseby [:huseby]]

Attachment: Bug_1238723.patch

Comment 4

[Dave Huseby [:huseby]]

Comment on attachment 8717725 [details] [diff] [review]
Bug_1238723.patch

this one is good to go.

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 8717725 [details] [diff] [review]
Bug_1238723.patch

Review of attachment 8717725 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe add a comment staying that we're only doing this since we don't yet support permissions on a per-user-context basis.

Comment 6

[Dave Huseby [:huseby]]

Attachment: Bug_1238723.patch

already r+ by :sicking.  this adds the comment he requested and adds a better commit message.

Comment 7

[Dave Huseby [:huseby]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4052526364b8

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a28d0f76c03b

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a28d0f76c03b