1238761 - Make APZ support multiple GeckoViews

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Switch NativePanZoomController to use native methods (v1)

This patch turns NativePanZoomController's MotionEvent handler into a
native method, and it adds the WrapForJNI annotations to all native
methods so that bindings will be automatically generated for them.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Add specializations of jni::Ref for primitive arrays (v1)

This patch adds specializations of jni::Ref for primitive arrays like
IntArray and FloatArray, so that the arrays can be accessed through the
GetElement, GetElements, and Length members.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Implement NativePanZoomController native methods (v1)

This patch adds the NPZCSupport class to nsWindow and use it to
implement the NPZC native methods that were implemented in
AndroidJNI.cpp. For HandleMotionEvent, the code also includes a portion
from AndroidJavaWrapper::MakeMultitouchEvent.

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Attach NativePanZoomController through GLController (v1)

This patch adds a way to attach a particular NativePanZoomController
instance held by LayerView to a particular nsWindow instance. Because
LayerView already calls GLController.SetLayerClient during
initialization, this patch renames it to attachToJava and modifies it to
accept an additional NPZC parameter. In the new AttachToJava
implementation, we create or reuse a NPZCSupport object and associate it
with the NPZC instance.

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Rewrite AndroidContentController to work with multiple nsWindows (v1)

This patch rewrites AndroidContentController to get rid of any
dependencies on a static nsWindow or APZC tree manager.

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Remove obsolete APZ code (v1)

With APZC supporting multiple nsWindows, this patch removes some
obsolete APZ code, including the previous implementation of
NativePanZoomController native methods in AndroidJNI.cpp, and the
various static members of nsWindow.

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Autogenerate constants for MotionEvent (v1)

This patch autogenerates constants for MotionEvent to replace the manual
definitions in AndroidJavaWrappers.

Comment 8

[Randall Barker [:rbarker]]

Comment on attachment 8706639 [details] [diff] [review]
Switch NativePanZoomController to use native methods (v1)

Review of attachment 8706639 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/java/org/mozilla/gecko/gfx/NativePanZoomController.java
@@ +45,5 @@
> +        final float[] toolMinor = new float[count];
> +
> +        final MotionEvent.PointerCoords coords = new MotionEvent.PointerCoords();
> +        final PointF point = !keepInViewCoordinates ? new PointF() : null;
> +        final float zoom = !keepInViewCoordinates ? mView.getViewportMetrics().zoomFactor : 0.0f;

If the default is 1.0f and not 0.0f you wouldn't need the if check on line 69. This obviously fine the way it is, I just get nervous when I see a variable set to 0.0 and then used in a divide later.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/84815007ef6b
https://hg.mozilla.org/integration/mozilla-inbound/rev/7ea026f1ff21
https://hg.mozilla.org/integration/mozilla-inbound/rev/efc13abebc11
https://hg.mozilla.org/integration/mozilla-inbound/rev/1424238752d3
https://hg.mozilla.org/integration/mozilla-inbound/rev/959e9cd05801
https://hg.mozilla.org/integration/mozilla-inbound/rev/a6812fd0c533
https://hg.mozilla.org/integration/mozilla-inbound/rev/644097e60a78

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/84815007ef6b
https://hg.mozilla.org/mozilla-central/rev/7ea026f1ff21
https://hg.mozilla.org/mozilla-central/rev/efc13abebc11
https://hg.mozilla.org/mozilla-central/rev/1424238752d3
https://hg.mozilla.org/mozilla-central/rev/959e9cd05801
https://hg.mozilla.org/mozilla-central/rev/a6812fd0c533
https://hg.mozilla.org/mozilla-central/rev/644097e60a78

Comment 11

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Fix startup bustage for non-APZ builds (v1)

Fix bustage for non-APZ builds. r=me

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/154d22a2a34c

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/154d22a2a34c