1238794 - Add setting under Privacy for "Close Private tabs"

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Firefox on iOS has a feature called:

Close Private tabs
When leaving Private Browsing

Pretty self explanatory but it basically force closes all the private tabs as soon as a user switches out of PB. No confirmation message, etc. I think this makes sense.

Thoughts?

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

If it's not too much investment, perhaps we can get some user studies (or A/B testing) going on this feature and see how people like it before implementing it ourselves.

Given our tabs tray setup, think the concept of "leaving private browsing" can be unclear so I'm not a fan of this (especially when "close all private tabs" is in the menu). If private browsing was more modal, I think this would make more sense.

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Michael Comella (:mcomella) from comment #1)
> If it's not too much investment, perhaps we can get some user studies (or
> A/B testing) going on this feature and see how people like it before
> implementing it ourselves.

We could, but I think features around privacy are one of those hard-to-measure, not often used, but extremely-delightful-when-I-do-use-it type cases. I think these little details that give our user more control are great things to show we care about privacy as well. Especially since these are 'off' by default, they're nice for users looking to have more "choice".

> Given our tabs tray setup, think the concept of "leaving private browsing"
> can be unclear so I'm not a fan of this (especially when "close all private
> tabs" is in the menu). If private browsing was more modal, I think this
> would make more sense.

Actually, I think this interaction of "leaving" is quite clear. Not only is the UI color now grey and purple, but you had to explicitly press a button to change modes - just like in iOS Firefox. 

Also, enabling this feature is a very intentional action so I don't think our users will be confused by what's happening after this pref is changed.

Comment 3

[:Margaret Leibovic]

I would like to see data that iOS users find this feature useful before we spend time implementing it on Android.

Comment 4

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.