1238795 - Images embedded in PDF overflow text areas

Status: RESOLVED FIXED

(Core :: Graphics, defect, P3)

Description

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Open PDF at http://file.mf.cz/896/4-01-16-E15-0801.pdf, go to page six and see that the image of the auto assembly line overflows into text.

Comment 1

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Attachment: Screenshot

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Testcase WFM on Win10 and Ubuntu 15.10 in a VM. Emma, are you able to bisect this down with mozregression? http://mozilla.github.io/mozregression/

Comment 3

[Yury Delendik (:yury)]

Looks like it affects only Skia. Suspected commits point to bug 1082598.

12:02.78 LOG: MainThread Bisector INFO Last good revision: d8e260e1535f0ff3877b21d6846380dedf449453
12:02.78 LOG: MainThread Bisector INFO First bad revision: 6630a176477ef903dcf3057db755abc43ba5018d
12:02.78 LOG: MainThread Bisector INFO Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=d8e260e1535f0ff3877b21d6846380dedf449453&tochange=6630a176477ef903dcf3057db755abc43ba5018d

Comment 4

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]: Visual regression when opening PDFs on platforms using the Skia backend.

Comment 5

[Yury Delendik (:yury)]

Attachment: Smaller test case (shield image must be clipped)

The smaller test case demonstrates and clipping on JPEG image is not working.

Comment 6

[Lee Salzman [:lsalzman]]

Preliminary investigation: this only occurs when Skia canvas is enabled. If "gfx.canvas.azure.accelerated" is true, for some reason the image fails to clip. If this pref is set to false (using the software Skia backend), then the image is properly clipped and does not cause the issue.

So it would seem that somewhere, somehow, the clipping is either not being set or buggy for the Skia GPU case.

I will see if I can find out more tomorrow.

Comment 7

[Lee Salzman [:lsalzman]]

Attachment: fix SkGpuDevice::drawBitmapRect to always update clips

This is actually a bug in Skia. If you use drawBitmapRect on a SkGpuDevice, and supply a bitmap that is not GPU-ified, then it fails to update the clipping on the device before drawing.

I filed an upstream change here: https://codereview.chromium.org/1584073007/

This patch is just the same as the upstream change.

Comment 8

[Lee Salzman [:lsalzman]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=dbeac66b06f8

Comment 9

[Ryan VanderMeulen [:RyanVM]]

No test? :(

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/22010c7e2ed1

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/22010c7e2ed1

Comment 12

[Lee Salzman [:lsalzman]]

Attachment: add reftest to verify that canvas drawImage respects clipping

Comment 13

[Yury Delendik (:yury)]

Comment on attachment 8708441 [details] [diff] [review]
add reftest to verify that canvas drawImage respects clipping

Review of attachment 8708441 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thanks.

Comment 14

[Lee Salzman [:lsalzman]]

Try run for reftest: https://treeherder.mozilla.org/#/jobs?repo=try&revision=470209a7f0ec

Comment 15

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/df4ac0fb09c3

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Woo, thanks :)

Comment 17

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking for 46 since this was a recent regression. Tests, yay!

Comment 18

[Liz Henry (:lizzard) (relman/hg->git project)]

Emma, first fixed bug in-product that you have found and filed. Bugmaster power!

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/df4ac0fb09c3

Comment 20

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #18)
> Emma, first fixed bug in-product that you have found and filed. Bugmaster
> power!

/me curtsies and fist bumps