Closed
Bug 1239096
Opened 10 years ago
Closed 10 years ago
Improve English in artifacts.py comments
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox46 fixed)
RESOLVED
FIXED
mozilla46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: nalexander, Assigned: bryce)
References
Details
Attachments
(2 files)
|
2.09 KB,
patch
|
Details | Diff | Splinter Review | |
|
58 bytes,
text/x-review-board-request
|
nalexander
:
review+
|
Details |
A tiny ticket to improve the comment at https://dxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/artifacts.py#421 and at https://dxr.mozilla.org/mozilla-central/source/python/mozbuild/mozbuild/artifacts.py#429.
Let's say *We* probably... throughout.
|
Assignee | |
Comment 1•10 years ago
|
||
|
Reporter | |
Comment 2•10 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/30589/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/30589/
Attachment #8707131 -
Flags: review?(nalexander)
|
|
Reporter | |
Comment 3•10 years ago
|
||
Comment on attachment 8707131 [details]
MozReview Request: Bug 1239096 - Improve English is artifacts.py comments. r?nalexander
https://reviewboard.mozilla.org/r/30589/#review27381
lgtm.
Attachment #8707131 -
Flags: review?(nalexander) → review+
|
|
Reporter | |
Comment 5•10 years ago
|
||
Comment on attachment 8707124 [details] [diff] [review]
1239096.patch
Canceled because this request was handled on Review Board.
Attachment #8707124 -
Flags: review?(nalexander)
|
||
Comment 6•10 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
|
||
Updated•8 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•