PlacesProvider Messaging API

RESOLVED FIXED in Firefox 48

Status

()

defect
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: tspurway, Assigned: oyiptong)

Tracking

(Blocks 1 bug)

unspecified
Firefox 48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

4 years ago
This API provides access to FX frecent history (places db) for the remote newtab page.
Assignee

Updated

3 years ago
Assignee: nobody → oyiptong
Assignee

Comment 3

3 years ago
Comment on attachment 8729195 [details]
MozReview Request: Bug 1239116 - Places messages enabled for remote newtab r?rrosario

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39287/diff/1-2/
Assignee

Comment 4

3 years ago
Comment on attachment 8729195 [details]
MozReview Request: Bug 1239116 - Places messages enabled for remote newtab r?rrosario

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39287/diff/2-3/
Assignee

Comment 5

3 years ago
Comment on attachment 8729195 [details]
MozReview Request: Bug 1239116 - Places messages enabled for remote newtab r?rrosario

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39287/diff/3-4/
Assignee

Updated

3 years ago
Attachment #8729194 - Attachment is obsolete: true
Attachment #8729194 - Flags: review?(msamuel)
Assignee

Comment 6

3 years ago
Comment on attachment 8729195 [details]
MozReview Request: Bug 1239116 - Places messages enabled for remote newtab r?rrosario

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39287/diff/4-5/
Assignee

Comment 7

3 years ago
Comment on attachment 8729195 [details]
MozReview Request: Bug 1239116 - Places messages enabled for remote newtab r?rrosario

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39287/diff/5-6/
Assignee

Comment 8

3 years ago
Comment on attachment 8729195 [details]
MozReview Request: Bug 1239116 - Places messages enabled for remote newtab r?rrosario

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39287/diff/6-7/
Attachment #8729195 - Attachment description: MozReview Request: Bug 1239116 - Places messages enabled for remote newtab r?emtwo → MozReview Request: Bug 1239116 - Places messages enabled for remote newtab r?r1cky
Assignee

Comment 9

3 years ago
Comment on attachment 8729195 [details]
MozReview Request: Bug 1239116 - Places messages enabled for remote newtab r?rrosario

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39287/diff/7-8/
Attachment #8729195 - Attachment description: MozReview Request: Bug 1239116 - Places messages enabled for remote newtab r?r1cky → MozReview Request: Bug 1239116 - Places messages enabled for remote newtab r?rrosario
Attachment #8729195 - Flags: review?(msamuel) → review?(rrosario)
https://reviewboard.mozilla.org/r/39283/#review41163

::: browser/components/newtab/tests/browser/browser_newtabmessages.js:116
(Diff revision 8)
> +    } = PlacesUtils.history;
> +
> +    return {
> +      uri: NetUtil.newURI(`${domain}${index}`),
> +      visitDate: timeDaysAgo(daysAgo),
> +      transition: (isTyped) ? TRANSITION_TYPED : TRANSITION_LINK,

nit: in this object literal you have a trailing comma and in the one above after `let` you don't.
Comment on attachment 8729195 [details]
MozReview Request: Bug 1239116 - Places messages enabled for remote newtab r?rrosario

https://reviewboard.mozilla.org/r/39287/#review41189

::: browser/components/newtab/tests/browser/browser_newtabmessages.js:136
(Diff revision 8)
> +
> +  /** Test Begins **/
> +
> +  let tabOptions = {
> +    gBrowser,
> +    url: testURL

nit: there are trailing comas everywhere except here. Is there something special with `let` or should we have one here too?
Attachment #8729195 - Flags: review?(rrosario) → review+
Assignee

Comment 12

3 years ago
https://reviewboard.mozilla.org/r/39287/#review41189

> nit: there are trailing comas everywhere except here. Is there something special with `let` or should we have one here too?

AFAIK `let` doesn't affect the requirement for not having trailing commas; it became valid syntax since ES5.
ES3 didn't allow for trailing commas. I'm personally indifferent about trailing commas.

Comment 14

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ce7ed1d0b81b
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.