NewTabPrefsProvider Messaging API

RESOLVED FIXED in Firefox 48

Status

()

defect
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: tspurway, Assigned: oyiptong)

Tracking

(Blocks 1 bug)

unspecified
Firefox 48
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox48 fixed)

Details

()

Attachments

(2 attachments, 1 obsolete attachment)

Reporter

Description

4 years ago
This API gives access to FX preferences from remote newtab page
Assignee

Updated

3 years ago
Assignee: nobody → oyiptong
Assignee

Comment 1

3 years ago
This bug also contains the NewTabWebChannel implementation
Assignee

Comment 2

3 years ago
The NewTabWebChannel design allows for newtab messages to be sent to the known newtab page origin, as well as localhost, when the newtab pref that allows to switch between localhost/remote modes.
Assignee

Updated

3 years ago
Blocks: 1249642
Assignee

Updated

3 years ago
Attachment #8726386 - Flags: review?(mconley) → review?(ursulasarracini)
Assignee

Updated

3 years ago
Attachment #8726387 - Flags: review?(mconley) → review?(ursulasarracini)
Assignee

Updated

3 years ago
Attachment #8726388 - Flags: review?(mconley) → review?(ursulasarracini)
Assignee

Comment 6

3 years ago
Comment on attachment 8726386 [details]
MozReview Request: Bug 1239118 - Switch linter to eslint for browser/components/newtab r?ursula

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37955/diff/1-2/
Attachment #8726386 - Attachment description: MozReview Request: Bug 1239118 - Switch linter to eslint for browser/components/newtab r?mconley → MozReview Request: Bug 1239118 - Switch linter to eslint for browser/components/newtab r?ursula
Assignee

Comment 7

3 years ago
Comment on attachment 8726387 [details]
MozReview Request: Bug 1239118 - Export an object named after module in NewTabRemoteResource r?ursula

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37957/diff/1-2/
Attachment #8726387 - Attachment description: MozReview Request: Bug 1239118 - Export an object named after module in NewTabRemoteResource r?mconley → MozReview Request: Bug 1239118 - Export an object named after module in NewTabRemoteResource r?ursula
Assignee

Comment 8

3 years ago
Comment on attachment 8726388 [details]
MozReview Request: Bug 1239118 - Send prefs to Remote Newtab page using WebChannel r?ursula

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37959/diff/1-2/
Attachment #8726388 - Attachment description: MozReview Request: Bug 1239118 - Send prefs to Remote Newtab page using WebChannel r?mconley → MozReview Request: Bug 1239118 - Send prefs to Remote Newtab page using WebChannel r?ursula
Assignee

Comment 9

3 years ago
Comment on attachment 8726388 [details]
MozReview Request: Bug 1239118 - Send prefs to Remote Newtab page using WebChannel r?ursula

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37959/diff/2-3/
Assignee

Comment 12

3 years ago
Comment on attachment 8726387 [details]
MozReview Request: Bug 1239118 - Export an object named after module in NewTabRemoteResource r?ursula

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37957/diff/2-3/
Assignee

Comment 13

3 years ago
Comment on attachment 8726388 [details]
MozReview Request: Bug 1239118 - Send prefs to Remote Newtab page using WebChannel r?ursula

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37959/diff/3-4/
Assignee

Updated

3 years ago
Attachment #8726386 - Attachment is obsolete: true
Attachment #8726386 - Flags: review?(ursulasarracini)
Assignee

Comment 14

3 years ago
Comment on attachment 8726387 [details]
MozReview Request: Bug 1239118 - Export an object named after module in NewTabRemoteResource r?ursula

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37957/diff/3-4/
Assignee

Comment 15

3 years ago
Comment on attachment 8726388 [details]
MozReview Request: Bug 1239118 - Send prefs to Remote Newtab page using WebChannel r?ursula

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37959/diff/4-5/
Assignee

Comment 17

3 years ago
Comment on attachment 8726388 [details]
MozReview Request: Bug 1239118 - Send prefs to Remote Newtab page using WebChannel r?ursula

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37959/diff/5-6/
Comment on attachment 8726387 [details]
MozReview Request: Bug 1239118 - Export an object named after module in NewTabRemoteResource r?ursula

https://reviewboard.mozilla.org/r/37957/#review35385
Attachment #8726387 - Flags: review?(ursulasarracini) → review+
Assignee

Comment 19

3 years ago
Comment on attachment 8726388 [details]
MozReview Request: Bug 1239118 - Send prefs to Remote Newtab page using WebChannel r?ursula

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37959/diff/6-7/
Assignee

Comment 20

3 years ago
Comment on attachment 8726388 [details]
MozReview Request: Bug 1239118 - Send prefs to Remote Newtab page using WebChannel r?ursula

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37959/diff/7-8/
Comment on attachment 8726388 [details]
MozReview Request: Bug 1239118 - Send prefs to Remote Newtab page using WebChannel r?ursula

https://reviewboard.mozilla.org/r/37959/#review36603

Do we need to worry about the couple of try failures happening?
Attachment #8726388 - Flags: review?(ursulasarracini) → review+
Assignee

Comment 22

3 years ago
https://reviewboard.mozilla.org/r/37959/#review36603

They look like intermittent errors unrelated to this bug

Comment 24

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2cced5c7c810
https://hg.mozilla.org/mozilla-central/rev/3d8dff59d031
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.