Closed
Bug 1239118
Opened 8 years ago
Closed 8 years ago
NewTabPrefsProvider Messaging API
Categories
(Firefox :: New Tab Page, defect)
Firefox
New Tab Page
Tracking
()
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: tspurway, Assigned: oyiptong)
References
(Blocks 1 open bug, )
Details
Attachments
(2 files, 1 obsolete file)
This API gives access to FX preferences from remote newtab page
Assignee | ||
Updated•8 years ago
|
Blocks: newtab-message-apis
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → oyiptong
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Comment 1•8 years ago
|
||
This bug also contains the NewTabWebChannel implementation
Assignee | ||
Comment 2•8 years ago
|
||
The NewTabWebChannel design allows for newtab messages to be sent to the known newtab page origin, as well as localhost, when the newtab pref that allows to switch between localhost/remote modes.
Assignee | ||
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/37955/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/37955/
Attachment #8726386 -
Flags: review?(mconley)
Assignee | ||
Comment 4•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/37957/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/37957/
Attachment #8726387 -
Flags: review?(mconley)
Assignee | ||
Comment 5•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/37959/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/37959/
Attachment #8726388 -
Flags: review?(mconley)
Assignee | ||
Updated•8 years ago
|
Attachment #8726386 -
Flags: review?(mconley) → review?(ursulasarracini)
Assignee | ||
Updated•8 years ago
|
Attachment #8726387 -
Flags: review?(mconley) → review?(ursulasarracini)
Assignee | ||
Updated•8 years ago
|
Attachment #8726388 -
Flags: review?(mconley) → review?(ursulasarracini)
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8726386 [details] MozReview Request: Bug 1239118 - Switch linter to eslint for browser/components/newtab r?ursula Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37955/diff/1-2/
Attachment #8726386 -
Attachment description: MozReview Request: Bug 1239118 - Switch linter to eslint for browser/components/newtab r?mconley → MozReview Request: Bug 1239118 - Switch linter to eslint for browser/components/newtab r?ursula
Assignee | ||
Comment 7•8 years ago
|
||
Comment on attachment 8726387 [details] MozReview Request: Bug 1239118 - Export an object named after module in NewTabRemoteResource r?ursula Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37957/diff/1-2/
Attachment #8726387 -
Attachment description: MozReview Request: Bug 1239118 - Export an object named after module in NewTabRemoteResource r?mconley → MozReview Request: Bug 1239118 - Export an object named after module in NewTabRemoteResource r?ursula
Assignee | ||
Comment 8•8 years ago
|
||
Comment on attachment 8726388 [details] MozReview Request: Bug 1239118 - Send prefs to Remote Newtab page using WebChannel r?ursula Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37959/diff/1-2/
Attachment #8726388 -
Attachment description: MozReview Request: Bug 1239118 - Send prefs to Remote Newtab page using WebChannel r?mconley → MozReview Request: Bug 1239118 - Send prefs to Remote Newtab page using WebChannel r?ursula
Assignee | ||
Comment 9•8 years ago
|
||
Comment on attachment 8726388 [details] MozReview Request: Bug 1239118 - Send prefs to Remote Newtab page using WebChannel r?ursula Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37959/diff/2-3/
Assignee | ||
Comment 10•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a9e2c18ed28
Assignee | ||
Comment 11•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b7328c13667
Assignee | ||
Comment 12•8 years ago
|
||
Comment on attachment 8726387 [details] MozReview Request: Bug 1239118 - Export an object named after module in NewTabRemoteResource r?ursula Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37957/diff/2-3/
Assignee | ||
Comment 13•8 years ago
|
||
Comment on attachment 8726388 [details] MozReview Request: Bug 1239118 - Send prefs to Remote Newtab page using WebChannel r?ursula Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37959/diff/3-4/
Assignee | ||
Updated•8 years ago
|
Attachment #8726386 -
Attachment is obsolete: true
Attachment #8726386 -
Flags: review?(ursulasarracini)
Assignee | ||
Comment 14•8 years ago
|
||
Comment on attachment 8726387 [details] MozReview Request: Bug 1239118 - Export an object named after module in NewTabRemoteResource r?ursula Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37957/diff/3-4/
Assignee | ||
Comment 15•8 years ago
|
||
Comment on attachment 8726388 [details] MozReview Request: Bug 1239118 - Send prefs to Remote Newtab page using WebChannel r?ursula Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37959/diff/4-5/
Assignee | ||
Comment 16•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8cc59631f432
Assignee | ||
Comment 17•8 years ago
|
||
Comment on attachment 8726388 [details] MozReview Request: Bug 1239118 - Send prefs to Remote Newtab page using WebChannel r?ursula Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37959/diff/5-6/
Comment 18•8 years ago
|
||
Comment on attachment 8726387 [details] MozReview Request: Bug 1239118 - Export an object named after module in NewTabRemoteResource r?ursula https://reviewboard.mozilla.org/r/37957/#review35385
Attachment #8726387 -
Flags: review?(ursulasarracini) → review+
Assignee | ||
Comment 19•8 years ago
|
||
Comment on attachment 8726388 [details] MozReview Request: Bug 1239118 - Send prefs to Remote Newtab page using WebChannel r?ursula Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37959/diff/6-7/
Assignee | ||
Comment 20•8 years ago
|
||
Comment on attachment 8726388 [details] MozReview Request: Bug 1239118 - Send prefs to Remote Newtab page using WebChannel r?ursula Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37959/diff/7-8/
Comment 21•8 years ago
|
||
Comment on attachment 8726388 [details] MozReview Request: Bug 1239118 - Send prefs to Remote Newtab page using WebChannel r?ursula https://reviewboard.mozilla.org/r/37959/#review36603 Do we need to worry about the couple of try failures happening?
Attachment #8726388 -
Flags: review?(ursulasarracini) → review+
Assignee | ||
Comment 22•8 years ago
|
||
https://reviewboard.mozilla.org/r/37959/#review36603 They look like intermittent errors unrelated to this bug
Comment 23•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2cced5c7c810 https://hg.mozilla.org/integration/mozilla-inbound/rev/3d8dff59d031
Comment 24•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2cced5c7c810 https://hg.mozilla.org/mozilla-central/rev/3d8dff59d031
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in
before you can comment on or make changes to this bug.
Description
•