Closed Bug 1239118 Opened 5 years ago Closed 4 years ago

NewTabPrefsProvider Messaging API

Categories

(Firefox :: New Tab Page, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 48
Tracking Status
firefox48 --- fixed

People

(Reporter: tspurway, Assigned: oyiptong)

References

(Blocks 1 open bug, )

Details

Attachments

(2 files, 1 obsolete file)

This API gives access to FX preferences from remote newtab page
Assignee: nobody → oyiptong
This bug also contains the NewTabWebChannel implementation
The NewTabWebChannel design allows for newtab messages to be sent to the known newtab page origin, as well as localhost, when the newtab pref that allows to switch between localhost/remote modes.
Blocks: 1249642
Attachment #8726386 - Flags: review?(mconley) → review?(ursulasarracini)
Attachment #8726387 - Flags: review?(mconley) → review?(ursulasarracini)
Attachment #8726388 - Flags: review?(mconley) → review?(ursulasarracini)
Comment on attachment 8726386 [details]
MozReview Request: Bug 1239118 - Switch linter to eslint for browser/components/newtab r?ursula

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37955/diff/1-2/
Attachment #8726386 - Attachment description: MozReview Request: Bug 1239118 - Switch linter to eslint for browser/components/newtab r?mconley → MozReview Request: Bug 1239118 - Switch linter to eslint for browser/components/newtab r?ursula
Comment on attachment 8726387 [details]
MozReview Request: Bug 1239118 - Export an object named after module in NewTabRemoteResource r?ursula

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37957/diff/1-2/
Attachment #8726387 - Attachment description: MozReview Request: Bug 1239118 - Export an object named after module in NewTabRemoteResource r?mconley → MozReview Request: Bug 1239118 - Export an object named after module in NewTabRemoteResource r?ursula
Comment on attachment 8726388 [details]
MozReview Request: Bug 1239118 - Send prefs to Remote Newtab page using WebChannel r?ursula

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37959/diff/1-2/
Attachment #8726388 - Attachment description: MozReview Request: Bug 1239118 - Send prefs to Remote Newtab page using WebChannel r?mconley → MozReview Request: Bug 1239118 - Send prefs to Remote Newtab page using WebChannel r?ursula
Comment on attachment 8726388 [details]
MozReview Request: Bug 1239118 - Send prefs to Remote Newtab page using WebChannel r?ursula

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37959/diff/2-3/
Comment on attachment 8726387 [details]
MozReview Request: Bug 1239118 - Export an object named after module in NewTabRemoteResource r?ursula

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37957/diff/2-3/
Comment on attachment 8726388 [details]
MozReview Request: Bug 1239118 - Send prefs to Remote Newtab page using WebChannel r?ursula

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37959/diff/3-4/
Attachment #8726386 - Attachment is obsolete: true
Attachment #8726386 - Flags: review?(ursulasarracini)
Comment on attachment 8726387 [details]
MozReview Request: Bug 1239118 - Export an object named after module in NewTabRemoteResource r?ursula

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37957/diff/3-4/
Comment on attachment 8726388 [details]
MozReview Request: Bug 1239118 - Send prefs to Remote Newtab page using WebChannel r?ursula

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37959/diff/4-5/
Comment on attachment 8726388 [details]
MozReview Request: Bug 1239118 - Send prefs to Remote Newtab page using WebChannel r?ursula

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37959/diff/5-6/
Comment on attachment 8726387 [details]
MozReview Request: Bug 1239118 - Export an object named after module in NewTabRemoteResource r?ursula

https://reviewboard.mozilla.org/r/37957/#review35385
Attachment #8726387 - Flags: review?(ursulasarracini) → review+
Comment on attachment 8726388 [details]
MozReview Request: Bug 1239118 - Send prefs to Remote Newtab page using WebChannel r?ursula

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37959/diff/6-7/
Comment on attachment 8726388 [details]
MozReview Request: Bug 1239118 - Send prefs to Remote Newtab page using WebChannel r?ursula

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/37959/diff/7-8/
Comment on attachment 8726388 [details]
MozReview Request: Bug 1239118 - Send prefs to Remote Newtab page using WebChannel r?ursula

https://reviewboard.mozilla.org/r/37959/#review36603

Do we need to worry about the couple of try failures happening?
Attachment #8726388 - Flags: review?(ursulasarracini) → review+
https://reviewboard.mozilla.org/r/37959/#review36603

They look like intermittent errors unrelated to this bug
https://hg.mozilla.org/mozilla-central/rev/2cced5c7c810
https://hg.mozilla.org/mozilla-central/rev/3d8dff59d031
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
You need to log in before you can comment on or make changes to this bug.