If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Validate the upstream JSON tracking protection list

RESOLVED FIXED

Status

()

Core
DOM: Security
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: francois, Assigned: mwobensmith)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
We have a test that runs in Travis when a pull request is submitted:

  https://github.com/mozilla-services/shavar-prod-lists/blob/master/scripts/test.sh

and checks that the file is valid JSON. However, we should do more, for example ensure that all domain names are ASCII-only.
Created attachment 8709487 [details] [review]
github_pull_request.txt
Attachment #8709487 - Flags: review?(francois)
(Reporter)

Comment 2

2 years ago
Comment on attachment 8709487 [details] [review]
github_pull_request.txt

Together with this commit:

  https://github.com/fmarier/shavar-prod-lists/commit/685d341a0bf0d20f569d2e1fe4b828210ad949ee

we can show that Matt's test script does work:

  https://travis-ci.org/fmarier/shavar-prod-lists/builds/103494477

and returns errors when the list is broken:

  https://travis-ci.org/fmarier/shavar-prod-lists/builds/103494023
Attachment #8709487 - Flags: review?(francois) → review+
(Reporter)

Comment 3

2 years ago
I submitted a PR to integrate this new script into the production repo:

  https://github.com/mozilla-services/shavar-prod-lists/pull/12
(Reporter)

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.