Closed
Bug 1239123
Opened 8 years ago
Closed 8 years ago
Validate the upstream JSON tracking protection list
Categories
(Core :: DOM: Security, defect)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
People
(Reporter: francois, Assigned: mwobensmith)
References
Details
Attachments
(1 file)
We have a test that runs in Travis when a pull request is submitted: https://github.com/mozilla-services/shavar-prod-lists/blob/master/scripts/test.sh and checks that the file is valid JSON. However, we should do more, for example ensure that all domain names are ASCII-only.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8709487 -
Flags: review?(francois)
|
Reporter | |
Comment 2•8 years ago
|
||
Comment on attachment 8709487 [details] [review] github_pull_request.txt Together with this commit: https://github.com/fmarier/shavar-prod-lists/commit/685d341a0bf0d20f569d2e1fe4b828210ad949ee we can show that Matt's test script does work: https://travis-ci.org/fmarier/shavar-prod-lists/builds/103494477 and returns errors when the list is broken: https://travis-ci.org/fmarier/shavar-prod-lists/builds/103494023
Attachment #8709487 -
Flags: review?(francois) → review+
|
|
Reporter | |
Comment 3•8 years ago
|
||
I submitted a PR to integrate this new script into the production repo: https://github.com/mozilla-services/shavar-prod-lists/pull/12
|
|
Reporter | |
Updated•8 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•