1239212 - NSPR_LOG_MODULE logs no longer include line return

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Jean-Yves Avenard [:jya]]

Note sure what the right component would be..

Start a local build with something like:

NSPR_LOG_MODULES=PlatformDecoderModule:5,MediaFormatReader:5 ./mach run

output:
[0x18af53560]: V/MediaFormatReader MediaFormatReader(11907c000)::ScheduleUpdate: SchedulingUpdate(Video)[0x18af53560]: V/MediaFormatReader MediaFormatReader(11907c000)::ScheduleUpdate: SchedulingUpdate(Audio)[0x18af53560]: V/MediaFormatReader MediaFormatReader(11907c000)::Update: Processing update for Video[0x18af53560]: V/MediaFormatReader MediaFormatReader(11907c000)::Update: Update(Video) ni=0 no=0 ie=0, in:0 out:0 qs=0 pending:0 waiting:0 ahead:1 sid:4294967295[0x18af53560]: V/MediaFormatReader MediaFormatReader(11907c000)::Update: No need for additional input (pending:0)[0x18af53560]: V/MediaFormatReader MediaFormatReader(11907c000)::Update: Processing update for Audio[0x18af53560]: V/MediaFormatReader MediaFormatReader(11907c000)::Update: Update(Audio) ni=0 no=0 ie=0, in:0 out:0 qs=0 pending:0 waiting:0 ahead:1 sid:4294967295[0x18af53560]: V/MediaFormatReader MediaFormatReader(11907c000)::Update: No need for additional input (pending:0)[0x18af53560]: V/MediaFormatReader MediaFormatReader(11907c000)::RequestAudioData: [0x18af53560]: V/MediaFormatReader MediaFormatReader(11907c000)::ScheduleUpdate: SchedulingUpdate(Audio)[0x18af53560]: V/MediaFormatReader MediaFormatReader(11907c000)::RequestVideoData: RequestVideoData(0, 0)[0x18af53560]: V/MediaFormatReader MediaFormatReader(11907c000)::ScheduleUpdate: SchedulingUpdate(Video)[0x18af53560]: V/MediaFormatReader MediaFormatReader(11907c000)::Update: Processing update for Audio[0x18af53560]: V/MediaFormatReader MediaFormatReader(11907c000)::Update: Update(Audio) ni=1 no=1 ie=0, in:0 out:0 qs=0 pending:0 waiting:0 ahead:0 sid:4294967295[0x18af53560]: V/MediaFormatReader MediaFormatReader(11907c000)::RequestDemuxSamples: Requesting extra demux Audio[0x18af53560]: V/MediaFormatReader MediaFormatReader(11907c000)::Update: Processing update for Video[0x18af53560]: V/MediaFormatReader MediaFormatReader(11907c000)::Update: Update(Video) ni=1 no=1 ie=0, in:0 

No more carriage return, makes the log unreadable. seems to be related to the extra D/ or V/ at the start of the log line (this is new)

Comment 1

[Jean-Yves Avenard [:jya]]

bisect tells me it's bug 1174972 the culprit...

https://hg.mozilla.org/integration/mozilla-inbound/rev/2aee7dd852a26df0222160c6220adc68014cb4ef

Comment 2

[Jean-Yves Avenard [:jya]]

There are no new lines *at all*: it's a single giant long single line.

Comment 3

[Eric Rahm [:erahm]]

PR_LogPrint had a feature of adding a newline if not present [1] that did not get included in the the new version. So for loggers that already include a newline in their messages it's not an issue, but for loggers that do not it definitely is.

To reach parity we need to append a newline to all messages.

[1] https://dxr.mozilla.org/mozilla-central/rev/e790bba372f14241addda469a4bdb7ab00786ab3/nsprpub/pr/src/io/prlog.c#493-498

Comment 4

[Masatoshi Kimura [:emk]]

(In reply to Eric Rahm [:erahm] from comment #3)
> To reach parity we need to append a newline to all messages.

Even if the message already has a newline? That's also messy.

Comment 5

[Eric Rahm [:erahm]]

(In reply to Masatoshi Kimura [:emk] from comment #4)
> (In reply to Eric Rahm [:erahm] from comment #3)
> > To reach parity we need to append a newline to all messages.
> 
> Even if the message already has a newline? That's also messy.

Sorry, yes we need to make sure every message ends in a newline, but only add one to those that are missing it.

Comment 6

[Eric Rahm [:erahm]]

Attachment: Append missing newlines to log messages

Tested against the provided STR on youtube.com as well as against 'nsThread' which provides newlines in its messages.

Comment 7

[Nathan Froyd [:froydnj]]

Comment on attachment 8707546 [details] [diff] [review]
Append missing newlines to log messages

Review of attachment 8707546 [details] [diff] [review]:
-----------------------------------------------------------------

Whoops!  Sorry for not catching that in review.

Comment 8

[Eric Rahm [:erahm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8ac5539028537a7bd623cbe05458b8b87ec319a1
Bug 1239212 - Append missing newlines to log messages. r=froydnj

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8ac553902853