Closed Bug 1239259 Opened 4 years ago Closed 4 years ago

Pass WebGL2 conformance test tex-mipmap-levels

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: ethlin, Assigned: ethlin)

References

()

Details

Attachments

(1 file)

error:
FAIL getError expected: INVALID_OPERATION. Was NO_ERROR : generateMipmap should fail for non-texture-filterable format
According to the spec[1], GL_INVALID_OPERATION is generated if the levelbaselevelbase array was not specified with an unsized internal format or a sized internal format that is both color-renderable and texture-filterable. So I add the check.

[1] https://www.khronos.org/opengles/sdk/docs/man3/html/glGenerateMipmap.xhtml
Attachment #8707368 - Flags: review?(jgilbert)
Assignee: nobody → ethlin
Blocks: webgl2
Attachment #8707368 - Flags: review?(jgilbert) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1ba31786ecfd
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.