1239259 - Pass WebGL2 conformance test tex-mipmap-levels

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Ethan Lin[:ethlin]]

error:
FAIL getError expected: INVALID_OPERATION. Was NO_ERROR : generateMipmap should fail for non-texture-filterable format

Comment 1

[Ethan Lin[:ethlin]]

Attachment: Fix generateMipmap

According to the spec[1], GL_INVALID_OPERATION is generated if the levelbaselevelbase array was not specified with an unsized internal format or a sized internal format that is both color-renderable and texture-filterable. So I add the check.

[1] https://www.khronos.org/opengles/sdk/docs/man3/html/glGenerateMipmap.xhtml

Comment 2

[Ethan Lin[:ethlin]]

try server result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=570ac1716ec1

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1ba31786ecfd

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1ba31786ecfd