Closed Bug 1239317 Opened 4 years ago Closed 4 years ago

Add a developer menu entry for about:debugging

Categories

(DevTools :: about:debugging, defect, P1)

defect

Tracking

(firefox47 fixed)

RESOLVED FIXED
Firefox 47
Tracking Status
firefox47 --- fixed

People

(Reporter: janx, Assigned: janx)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 3 obsolete files)

No description provided.
Discussions in https://public.etherpad-mozilla.org/p/about_debugging seem to go in favor of a single dedicated "Service Workers" menu entry in the Web Developer menu (wrench icon), with an optional second link in the Toolbox settings.

Tracking these with telemetry would be nice.
Patch implementing comment 2 but without a telemetry probe.
Attachment #8707456 - Attachment is obsolete: true
Priority: -- → P1
This patch adds a Service Workers entry to the Developer Menu that opens a new tab on "about:debugging#workers", allowing a user to view and debug all the installed service workers (and also other types of workers).

Reminder: The Web Developer menu can be reached in two different ways:
- Alt-menu (or App menu on Mac) > Tools > Web Developer
- Hamburger menu > Wrench

Ryan, could you please have a look?
Attachment #8725678 - Flags: review?(jryans)
Attachment #8712600 - Attachment is obsolete: true
Comment on attachment 8725678 [details] [diff] [review]
Add a Service Workers entry to the Web Developer menu.

Review of attachment 8725678 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/locales/en-US/aboutdebugging.dtd
@@ +1,5 @@
>  <!-- This Source Code Form is subject to the terms of the Mozilla Public
>     - License, v. 2.0. If a copy of the MPL was not distributed with this
>     - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
>  
> +<!ENTITY aboutDebugging.fullTitle                     "Debugging with Firefox Developer Tools">

Nit: probably don't need all this whitespace here

As a follow up idea, should the title include the currently selected topic, like Workers vs. Add-ons as well?
Attachment #8725678 - Flags: review?(jryans) → review+
Thanks Ryan!

(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #5)
> > +<!ENTITY aboutDebugging.fullTitle                     "Debugging with Firefox Developer Tools">
> 
> Nit: probably don't need all this whitespace here

You're right, I'll remove some of it.

> As a follow up idea, should the title include the currently selected topic,
> like Workers vs. Add-ons as well?

Good idea! I think eventually we'd like the title to include the currently selected target type (e.g. "workers") and the currently selected runtime (e.g. "local Firefox", "Google Chrome", "Firefox on Android", etc). That way a bookmark on about:debugging, showing workers from Fennec, could read "Debugging Workers on Firefox for Android with Firefox Developer Tools" or similar.

Additionally, inside the about:debugging page, maybe we'd like to show the word "Debugging" top-left, and just underneath it the current runtime, that way you'd visually read the same info as in the title ("Debugging", then "Firefox on Android", then all the tabs with "Workers" being selected).
Assignee: nobody → janx
Status: NEW → ASSIGNED
Addressed a nit.
Attachment #8725723 - Flags: review+
Attachment #8725678 - Attachment is obsolete: true
Keywords: checkin-needed
dev-doc-needed: To access about:debugging#workers, one can now use new menu entries described in comment 4.
Keywords: dev-doc-needed
Ryan, sheriffs seem to be on holiday. Could you please check this patch into fx-team for me?
Flags: needinfo?(jryans)
https://hg.mozilla.org/mozilla-central/rev/c98d9f463bf7
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
I have reproduced this according to (2015-10-29)

It's fixed on Latest Developer Edition:  Build ID (20160326004034), User Agent : Mozilla/5.0 (Windows NT 6.3; rv:47.0) Gecko/20100101 Firefox/47.0

Tested OS-- Windows8.1 32bit
QA Whiteboard: [testday-20160401]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.