1239392 - Accessing to a ico with img tag and height attribute, crash tab (e10s) or browser

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Leandro]

Attachment: mirtapbx.ico

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.80 Safari/537.36

Steps to reproduce:

Please create the following HTML file:

<img height="30px" src="mirtapbx.ico">




Actual results:

Mozilla crashes.

If you omit the "height" parameter, it works, if you set the height, it crashes.


Expected results:

Display the little .ico file

Comment 1

[YF (Yang)]

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=3d9c627fc1c5f623e63e0ff7a3758f6975b9db9b&tochange=c5f5f19feef1a2339a85f2acab0a900239011619

Comment 2

[Lee Salzman [:lsalzman]]

I was not able to reproduce this following the STR. Does this still occur on nightly, and on what platforms?

Comment 3

[YF (Yang)]

Confirmed fixed in Nightly.

Seems to https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2e50b83954e62d52d2ef294e850c4380d457d96a&tochange=977d78a8dd78afbc0153d37fd9887c3a200dce6a
82552109870e	Edwin Flores — Bug 1207958 - Fix heuristic for choosing which ICO sub-image to render - r=tn

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

If this landed on Jan. 15th in m-c that would be fixed in 46.

Comment 5

[guigs [:guigs] PST (please needinfo me!)]

I am not entirely sure if a new bug should be filed however there is a report from SUMO that this is happening again in 46.0.1 on Windows 7 and in Safe Mode

thread: https://support.mozilla.org/en-US/questions/1125149

I attached an image with the correlations, it looks like its under 100, some are seeing it again in 46.

Comment 6

[guigs [:guigs] PST (please needinfo me!)]

Attachment: crashcorelation.png

https://crash-stats.mozilla.com/signature/?product=Firefox&signature=skia%3A%3AConvolveHorizontally_SSE2

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

OK, looks like 47 is still affected too. Thanks. Edwin, what do you think?

Comment 8

[Loic]

(In reply to rmcguigan from comment #5)
> I am not entirely sure if a new bug should be filed however there is a
> report from SUMO that this is happening again in 46.0.1 on Windows 7 and in
> Safe Mode
> 
> thread: https://support.mozilla.org/en-US/questions/1125149
> 
> I attached an image with the correlations, it looks like its under 100, some
> are seeing it again in 46.

In fact, the issue you linked from SUMO has the same regression range but it's not fixed in 46/49 by bug Bug 1207958 contrary to this current bug.
The remaining crash is tracked in bug 1277741, so let's continue the discussion on the other bug.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Crash volume for signature 'skia::ConvolveHorizontally_SSE2':
 - nightly (version 50): 3 crashes from 2016-06-06.
 - aurora  (version 49): 3 crashes from 2016-06-07.
 - beta    (version 48): 100 crashes from 2016-06-06.
 - release (version 47): 615 crashes from 2016-05-31.
 - esr     (version 45): 14 crashes from 2016-04-07.

Crash volume on the last weeks:
             Week N-1   Week N-2   Week N-3   Week N-4   Week N-5   Week N-6   Week N-7
 - nightly          0          0          1          0          2          0          0
 - aurora           0          1          0          1          1          0          0
 - beta             6         15         17         16         16         19          3
 - release         78         97         91         92         88         86         36
 - esr              0          2          1          3          2          2          0

Affected platforms: Windows, Mac OS X, Linux

Comment 10

[Loic]

RMA bot is drunk, this current bug has been fixed since 46. And the other bug 1277741 with same crash signature is fixed in 48+.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

Crash volume for signature 'skia::ConvolveHorizontally_SSE2':
 - nightly (version 50): 3 crashes from 2016-06-06.
 - aurora  (version 49): 3 crashes from 2016-06-07.
 - beta    (version 48): 97 crashes from 2016-06-06.
 - release (version 47): 597 crashes from 2016-05-31.
 - esr     (version 45): 13 crashes from 2016-04-07.

Crash volume on the last weeks:
             Week N-1   Week N-2   Week N-3   Week N-4   Week N-5   Week N-6   Week N-7
 - nightly          0          0          1          0          2          0          0
 - aurora           0          1          0          1          1          0          0
 - beta             6         13         17         16         16         19          3
 - release         78         81         91         92         88         86         36
 - esr              0          1          1          3          2          2          0

Affected platforms: Windows, Mac OS X, Linux

Comment 12

[David Bolter [:davidb] (NeedInfo me for attention)]

(In reply to Loic from comment #10)
> RMA bot is drunk, this current bug has been fixed since 46. And the other
> bug 1277741 with same crash signature is fixed in 48+.

Hmmm. Maybe there are additional causes for the skia::ConvolveHorizontally_SSE2 signature?

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Calixte, fyi for commentary on the bot.  It's choosing the most recently active bug associated with the signature, right?  
We should likely open a new bug here.

Comment 14

[Calixte Denizet (:calixte)]

Liz, normally this bug is fixed now: https://github.com/mozilla/clouseau/commit/69ac3148168395e336e52968cebe3d38415e135d