1239488 - Add int/uint to vertex attrib data type

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Brad Kotsopoulos]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/47.0.2526.106 Safari/537.36

Steps to reproduce:

https://www.khronos.org/registry/webgl/sdk/tests/deqp/functional/gles3/instancedrendering.html?webglVersion=2&quiet=0

The last 8 test cases, for int/uint vectors.




Actual results:

In WebGLContext::ValidateBufferFetching we divide by the result of actualStride()

... = ((checked_byteLength - checked_sizeOfLastElement) / vd.actualStride()) + 1;

actualStride() calls componentSize() with type = LOCAL_GL_INT, which isn't handled in the enum, and returns 0.  We end up dividing by zero.

We get the following error message (as the divide by zero is caught by using checked ints):

FAIL instanced_rendering.types.int: GL error INVALID_OPERATION in drawArraysInstanced


Expected results:

We should return the size of int and uint.

Comment 1

[Brad Kotsopoulos]

Attachment: vertex_attrib_data_v1.pat

Change to add int/uint support to switch statement.

Comment 2

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8707650 [details] [diff] [review]
vertex_attrib_data_v1.pat

Review of attachment 8707650 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLVertexAttribData.h
@@ +62,5 @@
>          case LOCAL_GL_FLOAT:
>              return sizeof(GLfloat);
>  
>          default:
> +            MOZ_ASSERT(!"Should never get here!");

MOZ_ASSERT(false, "...

Comment 3

[Brad Kotsopoulos]

Attachment: vertex_attrib_data_v2

Fixing assert.

Comment 4

[Brad Kotsopoulos]

Results from push to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=9c1b4d54c6f5

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b113b4874656

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b113b4874656