1239495 - replace "JS::ubi::RootList" with "GC Roots" in the dominator tree view

Status: RESOLVED FIXED

(DevTools :: Memory, defect, P2)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Easier for folks not familiar with the implementation (eg everyone) to understand.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Label the GC roots in the dominator tree

Before this patch, we used the underlying root list's C++ type as the label of
the GC roots node in the dominator tree. This patch changes that label to "GC
Roots", which does not require knowing our implementation of heap snapshots to
understand.

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=55816ceb9354

Comment 3

[Julian Descottes [:jdescottes]]

Comment on attachment 8709616 [details] [diff] [review]
Label the GC roots in the dominator tree

Review of attachment 8709616 [details] [diff] [review]:
-----------------------------------------------------------------

Great, ship it!

::: devtools/client/locales/en-US/memory.properties
@@ +106,5 @@
>  tree-item.load-more=Load more…
>  
> +# LOCALIZATION NOTE (tree-item.rootlist): The label for root of the dominator
> +# tree.
> +tree-item.rootlist=GC Roots

nit : "The label for root of the dominator tree" -> "The label for `the` root of the dominator tree" ?

Comment 4

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: Label the GC roots in the dominator tree

Updated the comment typo as the review pointed out.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/ccf0e6c22997

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ccf0e6c22997

Comment 7

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected