Closed Bug 1239495 Opened 4 years ago Closed 4 years ago

replace "JS::ubi::RootList" with "GC Roots" in the dominator tree view

Categories

(DevTools :: Memory, defect, P2)

defect

Tracking

(firefox46 fixed)

RESOLVED FIXED
Firefox 46
Tracking Status
firefox46 --- fixed

People

(Reporter: fitzgen, Assigned: fitzgen)

References

Details

(Whiteboard: [polish-backlog][difficulty=easy])

Attachments

(1 file, 1 obsolete file)

Easier for folks not familiar with the implementation (eg everyone) to understand.
Whiteboard: [polish-backlog][difficulty=easy]
Before this patch, we used the underlying root list's C++ type as the label of
the GC roots node in the dominator tree. This patch changes that label to "GC
Roots", which does not require knowing our implementation of heap snapshots to
understand.
Attachment #8709616 - Flags: review?(jdescottes)
Comment on attachment 8709616 [details] [diff] [review]
Label the GC roots in the dominator tree

Review of attachment 8709616 [details] [diff] [review]:
-----------------------------------------------------------------

Great, ship it!

::: devtools/client/locales/en-US/memory.properties
@@ +106,5 @@
>  tree-item.load-more=Load more…
>  
> +# LOCALIZATION NOTE (tree-item.rootlist): The label for root of the dominator
> +# tree.
> +tree-item.rootlist=GC Roots

nit : "The label for root of the dominator tree" -> "The label for `the` root of the dominator tree" ?
Attachment #8709616 - Flags: review?(jdescottes) → review+
Updated the comment typo as the review pointed out.
Attachment #8709740 - Flags: review+
Attachment #8709616 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/ccf0e6c22997
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.