Closed Bug 1239498 Opened 9 years ago Closed 9 years ago

Use Stackwalk64 on win x64

Categories

(Core :: Gecko Profiler, defect)

Product:
Core
Component:
Gecko Profiler
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla46
Tracking Flags:
Tracking Status
firefox46 --- fixed

People

(Reporter: BenWa, Assigned: BenWa)

Details

Attachments

(2 files, 1 obsolete file)

patch
1.56 KB, patch
jrmuizel
: review+
Details | Diff | Splinter Review
part 2: Don't ask for FPO on win64
1.06 KB, patch
ehsan.akhgari
: review+
Details | Diff | Splinter Review
Currently unwinding is broken on win x64 builds, which is now the default nightly configuration. A quick investigation reveals that you can't disable frame pointer omission (FPO) on 64-bit and even if you could system libraries have FPO so it's a losing battle. We should go back to using Stackwalk64 which will use the unwind info.
Attached patch patch — — Splinter Review
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
Attachment #8707662 - Flags: review?(jmuizelaar)
Attachment #8707662 - Flags: review?(jmuizelaar) → review+
Attachment #8707663 - Flags: review?(ehsan)
patch message
Attachment #8707663 - Attachment is obsolete: true
Attachment #8707663 - Flags: review?(ehsan)
Attachment #8707665 - Flags: review?(ehsan)
Whiteboard: leave-open
Attachment #8707665 - Flags: review?(ehsan) → review+
Whiteboard: leave-open
https://hg.mozilla.org/mozilla-central/rev/07abc6a269c9
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: